unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Ergus <spacibba@aol.com>
Cc: 34513@debbugs.gnu.org
Subject: bug#34513: Fwd: Re: bug#34513: display-line-numbers in term mode
Date: Wed, 27 Feb 2019 20:15:13 +0200	[thread overview]
Message-ID: <83y361jdxq.fsf@gnu.org> (raw)
In-Reply-To: <20190227174656.ysbxuhz332gvhkpq@Ergus> (message from Ergus on Wed, 27 Feb 2019 18:46:56 +0100)

> Date: Wed, 27 Feb 2019 18:46:56 +0100
> From: Ergus <spacibba@aol.com>
> 
> Yes I see the limitations, specially when the
> (line-number-display-width) changes due to user interaction. The problem
> is that for a real fix maybe it needs a hook like
> line-number-display-width-change (or equivalent) where to add actions, I
> suppose there are potentially other modes with same issue.

There's no such hook (and providing it would be very hard and largely
useless, as I explained in the past).  Modes which need such
adjustments can use window-scroll-functions and/or
pre-redisplay-functions.  You can see an example in tabulated-list.el.

> The simplest to do (in my opinion) is to make the numbers not available
> at all in term mode and avoid display-line-numbers to be enabled in term
> mode.

Based on prior experience, I very much doubt that this solution will
be accepted by the community.  It's better to allow turning on line
numbers in this mode as well.





  reply	other threads:[~2019-02-27 18:15 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-17 14:19 bug#34513: display-line-numbers in term mode Ergus
2019-02-27 15:26 ` Stefan Monnier
2019-02-27 16:05   ` Eli Zaretskii
2019-02-27 16:40     ` Stefan Monnier
2019-02-27 17:06       ` Eli Zaretskii
2019-02-27 17:21         ` Stefan Monnier
2019-02-27 17:33           ` Eli Zaretskii
     [not found]           ` <<831s3tkufj.fsf@gnu.org>
2019-02-27 18:00             ` Drew Adams
2019-02-27 18:20               ` Eli Zaretskii
     [not found]           ` <<<831s3tkufj.fsf@gnu.org>
     [not found]             ` <<9f8f0712-1187-4ce3-bd2c-af44cf00927d@default>
     [not found]               ` <<83wolljdpe.fsf@gnu.org>
2019-02-27 19:04                 ` Drew Adams
2020-09-20 18:30   ` Lars Ingebrigtsen
2020-09-20 18:50     ` Eli Zaretskii
2020-09-20 19:56       ` Lars Ingebrigtsen
2020-09-21  2:27         ` Eli Zaretskii
2020-09-21 14:10           ` Lars Ingebrigtsen
2019-02-27 17:46 ` bug#34513: Fwd: " Ergus
2019-02-27 18:15   ` Eli Zaretskii [this message]
2019-10-20 22:54 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-10-21  6:51   ` Eli Zaretskii
2019-10-21 21:44     ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-10-22 15:11       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83y361jdxq.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=34513@debbugs.gnu.org \
    --cc=spacibba@aol.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).