From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34513: Fwd: Re: bug#34513: display-line-numbers in term mode Date: Wed, 27 Feb 2019 20:15:13 +0200 Message-ID: <83y361jdxq.fsf@gnu.org> References: <20190217141940.62v754v46qwfcs2i@Ergus> <20190227174656.ysbxuhz332gvhkpq@Ergus> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="15493"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34513@debbugs.gnu.org To: Ergus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 27 19:31:57 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gz3zo-0003uW-BT for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Feb 2019 19:31:56 +0100 Original-Received: from localhost ([127.0.0.1]:48916 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gz3zn-0006Xi-7W for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Feb 2019 13:31:55 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39342) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gz3zW-0005UE-QL for bug-gnu-emacs@gnu.org; Wed, 27 Feb 2019 13:31:41 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gz3kU-0003oA-Te for bug-gnu-emacs@gnu.org; Wed, 27 Feb 2019 13:16:09 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40777) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gz3kQ-0003ls-UZ for bug-gnu-emacs@gnu.org; Wed, 27 Feb 2019 13:16:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gz3kQ-0006vP-CJ for bug-gnu-emacs@gnu.org; Wed, 27 Feb 2019 13:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Feb 2019 18:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34513 X-GNU-PR-Package: emacs Original-Received: via spool by 34513-submit@debbugs.gnu.org id=B34513.155129134726594 (code B ref 34513); Wed, 27 Feb 2019 18:16:02 +0000 Original-Received: (at 34513) by debbugs.gnu.org; 27 Feb 2019 18:15:47 +0000 Original-Received: from localhost ([127.0.0.1]:54321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gz3k9-0006ur-RV for submit@debbugs.gnu.org; Wed, 27 Feb 2019 13:15:46 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50925) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gz3k7-0006ud-VO for 34513@debbugs.gnu.org; Wed, 27 Feb 2019 13:15:44 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53322) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gz3js-0003PQ-TX; Wed, 27 Feb 2019 13:15:30 -0500 Original-Received: from [176.228.60.248] (port=4798 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gz3jh-0006SG-N5; Wed, 27 Feb 2019 13:15:24 -0500 In-reply-to: <20190227174656.ysbxuhz332gvhkpq@Ergus> (message from Ergus on Wed, 27 Feb 2019 18:46:56 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155869 Archived-At: > Date: Wed, 27 Feb 2019 18:46:56 +0100 > From: Ergus > > Yes I see the limitations, specially when the > (line-number-display-width) changes due to user interaction. The problem > is that for a real fix maybe it needs a hook like > line-number-display-width-change (or equivalent) where to add actions, I > suppose there are potentially other modes with same issue. There's no such hook (and providing it would be very hard and largely useless, as I explained in the past). Modes which need such adjustments can use window-scroll-functions and/or pre-redisplay-functions. You can see an example in tabulated-list.el. > The simplest to do (in my opinion) is to make the numbers not available > at all in term mode and avoid display-line-numbers to be enabled in term > mode. Based on prior experience, I very much doubt that this solution will be accepted by the community. It's better to allow turning on line numbers in this mode as well.