unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Ergus <spacibba@aol.com>
To: 34513@debbugs.gnu.org
Subject: bug#34513: Fwd: Re: bug#34513: display-line-numbers in term mode
Date: Wed, 27 Feb 2019 18:46:56 +0100	[thread overview]
Message-ID: <20190227174656.ysbxuhz332gvhkpq@Ergus> (raw)
In-Reply-To: <20190217141940.62v754v46qwfcs2i@Ergus>

Yes I see the limitations, specially when the
(line-number-display-width) changes due to user interaction. The problem
is that for a real fix maybe it needs a hook like
line-number-display-width-change (or equivalent) where to add actions, I
suppose there are potentially other modes with same issue. But I think
this is a bit overkill because it will require a redraw and the previous
lines will be modified.

The simplest to do (in my opinion) is to make the numbers not available
at all in term mode and avoid display-line-numbers to be enabled in term
mode. It will keep both the display-line-numbers and term.el
implementations simpler. If a user really needs the numbers in the
future then we can consider other solutions. But it makes not too much
sense actually to have the line numbers in term mode.

My report was because I faced the existent issue by default and it
required an action in my config to avoid exposing it, not because
I wanted the numbers.

But again, you have much much more experience on this and a better
opinion about what should be there or not.







  parent reply	other threads:[~2019-02-27 17:46 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-17 14:19 bug#34513: display-line-numbers in term mode Ergus
2019-02-27 15:26 ` Stefan Monnier
2019-02-27 16:05   ` Eli Zaretskii
2019-02-27 16:40     ` Stefan Monnier
2019-02-27 17:06       ` Eli Zaretskii
2019-02-27 17:21         ` Stefan Monnier
2019-02-27 17:33           ` Eli Zaretskii
     [not found]           ` <<831s3tkufj.fsf@gnu.org>
2019-02-27 18:00             ` Drew Adams
2019-02-27 18:20               ` Eli Zaretskii
     [not found]           ` <<<831s3tkufj.fsf@gnu.org>
     [not found]             ` <<9f8f0712-1187-4ce3-bd2c-af44cf00927d@default>
     [not found]               ` <<83wolljdpe.fsf@gnu.org>
2019-02-27 19:04                 ` Drew Adams
2020-09-20 18:30   ` Lars Ingebrigtsen
2020-09-20 18:50     ` Eli Zaretskii
2020-09-20 19:56       ` Lars Ingebrigtsen
2020-09-21  2:27         ` Eli Zaretskii
2020-09-21 14:10           ` Lars Ingebrigtsen
2019-02-27 17:46 ` Ergus [this message]
2019-02-27 18:15   ` bug#34513: Fwd: " Eli Zaretskii
2019-10-20 22:54 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-10-21  6:51   ` Eli Zaretskii
2019-10-21 21:44     ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-10-22 15:11       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190227174656.ysbxuhz332gvhkpq@Ergus \
    --to=spacibba@aol.com \
    --cc=34513@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).