From: Eli Zaretskii <eliz@gnu.org>
To: Gregory Heytings <gregory@heytings.org>
Cc: robert@capuchin.co.uk, 47969@debbugs.gnu.org
Subject: bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command
Date: Tue, 04 May 2021 16:17:19 +0300 [thread overview]
Message-ID: <83y2cu4p0g.fsf@gnu.org> (raw)
In-Reply-To: <1a73bd6c69e27aed1fbd@heytings.org> (message from Gregory Heytings on Tue, 04 May 2021 13:04:58 +0000)
> Date: Tue, 04 May 2021 13:04:58 +0000
> From: Gregory Heytings <gregory@heytings.org>
> cc: rudalics@gmx.at, 47969@debbugs.gnu.org, robert@capuchin.co.uk
>
> > The problem is that you suggest to change handle-select-window which is
> > a general interactive function that has a "key" binding. I'd like to
> > restrict the effect of the change only to auto-selection of windows by
> > the mouse, because I see no reason to make the effect more broad.
>
> Okay. The problem is that mouse-autoselect-window-select is not called
> with mouse-autoselect-window t, the autoselection is immediate. So
> handle-select-window is called immediately, and AFAICS there is at that
> point no way to detect whether the select-window event came from an
> autoselection or from an explicit selection. What I would do to narrow
> the possible effect is to replace the
>
> (window-minibuffer-p)
>
> in my patch with
>
> (and mouse-autoselect-window (window-minibuffer-p))
>
> Would you agree with that?
Yes, this is better. But I wonder if we can do better yet. I see
that we already have machinery in place to delay auto-selection for
some reason or other -- can we use this feature in this case, perhaps?
See mouse-autoselect-window-state and its users. Perhaps we can delay
the auto-selection until after the key sequence started by ESC is
processed?
> >> After pressing ESC, keyboard commands do not do run what one would
> >> expect, e.g. C-x o does not run other-window but (in an Elisp buffer)
> >> eval-defun (i.e. C-M-x) followed by self-insert-command ('o').
> >
> > Sorry, I don't think I understand what you are trying to say here, nor
> > how it is relevant to the issue at hand. Please clarify.
> >
>
> I replied to your "switching windows by a keyboard command [...] is an
> intentional user action", to mention that in this particular case (after
> pressing ESC) the keyboard commands to switch windows do not behave as
> expected (unlike clicking).
Ah, you mean only keys from special-event-map will have such an
effect. Most probably, yes.
next prev parent reply other threads:[~2021-05-04 13:17 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 13:00 bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command Robert Marshall
2021-04-24 17:29 ` Gregory Heytings
2021-04-25 6:41 ` Robert Marshall
2021-04-25 9:58 ` Gregory Heytings
2021-04-25 12:28 ` Robert Marshall
2021-04-25 12:29 ` Gregory Heytings
2021-05-01 20:20 ` Gregory Heytings
2021-05-02 6:40 ` Eli Zaretskii
2021-05-03 9:07 ` Lars Ingebrigtsen
2021-05-03 11:54 ` Eli Zaretskii
2021-05-03 12:15 ` Gregory Heytings
2021-05-03 12:18 ` Eli Zaretskii
2021-05-02 7:39 ` martin rudalics
2021-05-02 8:01 ` Robert Marshall
2021-05-03 8:42 ` Gregory Heytings
2021-05-03 9:38 ` martin rudalics
2021-05-03 9:41 ` Gregory Heytings
2021-05-03 11:19 ` Gregory Heytings
2021-05-03 12:02 ` martin rudalics
2021-05-03 12:09 ` Eli Zaretskii
2021-05-03 12:20 ` Gregory Heytings
2021-05-03 17:31 ` martin rudalics
2021-05-03 17:46 ` Eli Zaretskii
2021-05-04 7:41 ` Gregory Heytings
2021-05-04 11:59 ` Eli Zaretskii
2021-05-04 13:04 ` Gregory Heytings
2021-05-04 13:17 ` Eli Zaretskii [this message]
2021-05-04 13:26 ` Gregory Heytings
2021-05-04 14:02 ` Eli Zaretskii
2021-05-04 14:43 ` Gregory Heytings
2021-05-04 15:19 ` Eli Zaretskii
2021-05-05 7:25 ` martin rudalics
2021-05-05 9:02 ` Gregory Heytings
2021-05-05 9:25 ` martin rudalics
2021-05-05 9:40 ` Gregory Heytings
2021-05-05 11:24 ` martin rudalics
2021-05-05 12:06 ` Eli Zaretskii
2021-05-06 7:44 ` martin rudalics
2021-05-06 8:06 ` Eli Zaretskii
2021-05-06 13:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-06 13:50 ` Gregory Heytings
2021-05-06 14:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-08 12:38 ` Eli Zaretskii
2021-05-08 13:36 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-25 8:52 ` Gregory Heytings
2021-05-25 19:40 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y2cu4p0g.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=47969@debbugs.gnu.org \
--cc=gregory@heytings.org \
--cc=robert@capuchin.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).