From: Gregory Heytings <gregory@heytings.org>
To: Robert Marshall <robert@capuchin.co.uk>
Cc: 47969@debbugs.gnu.org
Subject: bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command
Date: Sat, 01 May 2021 20:20:16 +0000 [thread overview]
Message-ID: <4edb1435266ad41487a5@heytings.org> (raw)
In-Reply-To: <677a04021b6d6347bbd2@heytings.org>
[-- Attachment #1: Type: text/plain, Size: 188 bytes --]
Patch attached. Could you please test it, and confirm that it correctly
fixes the issue?
Cc'ing Martin, who authored most of the handle-select-window function.
The recipe is upthread.
[-- Attachment #2: Type: text/x-diff, Size: 1124 bytes --]
From cfc85ca0f16b194367ecfb195a237b955f81088b Mon Sep 17 00:00:00 2001
From: Gregory Heytings <gregory@heytings.org>
Date: Sat, 1 May 2021 20:17:30 +0000
Subject: [PATCH] Do not switch to other window when minibuffer is selected
* lisp/window.el (handle-select-window): Do not silently switch to other
window when minibuffer is selected, which can happen with
mouse-autoselect-window t (Bug#47969).
---
lisp/window.el | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lisp/window.el b/lisp/window.el
index cf5752113d..77609a794b 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -10048,6 +10048,8 @@ handle-select-window
;; already selected.
(and (not (eq frame (selected-frame)))
(frame-parameter frame 'no-accept-focus))
+ ;; Don't switch if minibuffer window is selected.
+ (window-minibuffer-p)
;; Don't switch to minibuffer window unless it's active.
(and (window-minibuffer-p window)
(not (minibuffer-window-active-p window))))
--
2.30.2
next prev parent reply other threads:[~2021-05-01 20:20 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 13:00 bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command Robert Marshall
2021-04-24 17:29 ` Gregory Heytings
2021-04-25 6:41 ` Robert Marshall
2021-04-25 9:58 ` Gregory Heytings
2021-04-25 12:28 ` Robert Marshall
2021-04-25 12:29 ` Gregory Heytings
2021-05-01 20:20 ` Gregory Heytings [this message]
2021-05-02 6:40 ` Eli Zaretskii
2021-05-03 9:07 ` Lars Ingebrigtsen
2021-05-03 11:54 ` Eli Zaretskii
2021-05-03 12:15 ` Gregory Heytings
2021-05-03 12:18 ` Eli Zaretskii
2021-05-02 7:39 ` martin rudalics
2021-05-02 8:01 ` Robert Marshall
2021-05-03 8:42 ` Gregory Heytings
2021-05-03 9:38 ` martin rudalics
2021-05-03 9:41 ` Gregory Heytings
2021-05-03 11:19 ` Gregory Heytings
2021-05-03 12:02 ` martin rudalics
2021-05-03 12:09 ` Eli Zaretskii
2021-05-03 12:20 ` Gregory Heytings
2021-05-03 17:31 ` martin rudalics
2021-05-03 17:46 ` Eli Zaretskii
2021-05-04 7:41 ` Gregory Heytings
2021-05-04 11:59 ` Eli Zaretskii
2021-05-04 13:04 ` Gregory Heytings
2021-05-04 13:17 ` Eli Zaretskii
2021-05-04 13:26 ` Gregory Heytings
2021-05-04 14:02 ` Eli Zaretskii
2021-05-04 14:43 ` Gregory Heytings
2021-05-04 15:19 ` Eli Zaretskii
2021-05-05 7:25 ` martin rudalics
2021-05-05 9:02 ` Gregory Heytings
2021-05-05 9:25 ` martin rudalics
2021-05-05 9:40 ` Gregory Heytings
2021-05-05 11:24 ` martin rudalics
2021-05-05 12:06 ` Eli Zaretskii
2021-05-06 7:44 ` martin rudalics
2021-05-06 8:06 ` Eli Zaretskii
2021-05-06 13:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-06 13:50 ` Gregory Heytings
2021-05-06 14:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-08 12:38 ` Eli Zaretskii
2021-05-08 13:36 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-25 8:52 ` Gregory Heytings
2021-05-25 19:40 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4edb1435266ad41487a5@heytings.org \
--to=gregory@heytings.org \
--cc=47969@debbugs.gnu.org \
--cc=robert@capuchin.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).