From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command Date: Tue, 04 May 2021 16:17:19 +0300 Message-ID: <83y2cu4p0g.fsf@gnu.org> References: <24706.50397.801563.461736@capuchin.co.uk> <7ee648e84004b7745946@heytings.org> <24709.3891.605753.919647@capuchin.co.uk> <677a04021b23aa2d7c9f@heytings.org> <24709.24669.871737.299611@capuchin.co.uk> <677a04021b6d6347bbd2@heytings.org> <4edb1435266ad41487a5@heytings.org> <8fdeca1f-7d34-c95a-0f2d-5550dea34512@gmx.at> <242e45b6-6dee-c85a-2ac8-67b2adeb93b5@gmx.at> <838s4w6mua.fsf@gnu.org> <83y2cv6773.fsf@gnu.org> <1a73bd6c69efd6282e57@heytings.org> <83bl9q676g.fsf@gnu.org> <1a73bd6c69e27aed1fbd@heytings.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13166"; mail-complaints-to="usenet@ciao.gmane.io" Cc: robert@capuchin.co.uk, 47969@debbugs.gnu.org To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 04 15:18:33 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lduwa-0003Je-MA for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 May 2021 15:18:32 +0200 Original-Received: from localhost ([::1]:34792 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lduwZ-0004rH-NA for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 May 2021 09:18:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41040) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lduw6-0004mh-Pz for bug-gnu-emacs@gnu.org; Tue, 04 May 2021 09:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41626) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lduw6-0002U9-Im for bug-gnu-emacs@gnu.org; Tue, 04 May 2021 09:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lduw6-0007gG-FF for bug-gnu-emacs@gnu.org; Tue, 04 May 2021 09:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 May 2021 13:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47969 X-GNU-PR-Package: emacs Original-Received: via spool by 47969-submit@debbugs.gnu.org id=B47969.162013426529517 (code B ref 47969); Tue, 04 May 2021 13:18:02 +0000 Original-Received: (at 47969) by debbugs.gnu.org; 4 May 2021 13:17:45 +0000 Original-Received: from localhost ([127.0.0.1]:53172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lduvp-0007g1-0x for submit@debbugs.gnu.org; Tue, 04 May 2021 09:17:45 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60888) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lduvm-0007fv-PT for 47969@debbugs.gnu.org; Tue, 04 May 2021 09:17:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51453) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lduvf-0002F0-Uc; Tue, 04 May 2021 09:17:36 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2173 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lduvf-0008LP-99; Tue, 04 May 2021 09:17:35 -0400 In-Reply-To: <1a73bd6c69e27aed1fbd@heytings.org> (message from Gregory Heytings on Tue, 04 May 2021 13:04:58 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205608 Archived-At: > Date: Tue, 04 May 2021 13:04:58 +0000 > From: Gregory Heytings > cc: rudalics@gmx.at, 47969@debbugs.gnu.org, robert@capuchin.co.uk > > > The problem is that you suggest to change handle-select-window which is > > a general interactive function that has a "key" binding. I'd like to > > restrict the effect of the change only to auto-selection of windows by > > the mouse, because I see no reason to make the effect more broad. > > Okay. The problem is that mouse-autoselect-window-select is not called > with mouse-autoselect-window t, the autoselection is immediate. So > handle-select-window is called immediately, and AFAICS there is at that > point no way to detect whether the select-window event came from an > autoselection or from an explicit selection. What I would do to narrow > the possible effect is to replace the > > (window-minibuffer-p) > > in my patch with > > (and mouse-autoselect-window (window-minibuffer-p)) > > Would you agree with that? Yes, this is better. But I wonder if we can do better yet. I see that we already have machinery in place to delay auto-selection for some reason or other -- can we use this feature in this case, perhaps? See mouse-autoselect-window-state and its users. Perhaps we can delay the auto-selection until after the key sequence started by ESC is processed? > >> After pressing ESC, keyboard commands do not do run what one would > >> expect, e.g. C-x o does not run other-window but (in an Elisp buffer) > >> eval-defun (i.e. C-M-x) followed by self-insert-command ('o'). > > > > Sorry, I don't think I understand what you are trying to say here, nor > > how it is relevant to the issue at hand. Please clarify. > > > > I replied to your "switching windows by a keyboard command [...] is an > intentional user action", to mention that in this particular case (after > pressing ESC) the keyboard commands to switch windows do not behave as > expected (unlike clicking). Ah, you mean only keys from special-event-map will have such an effect. Most probably, yes.