From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: psainty@orcon.net.nz, 1343@debbugs.gnu.org,
27397@debbugs.gnu.org, michael.albinus@gmx.de, dgutov@yandex.ru
Subject: bug#1343: bug#27397: [PATCH] New commands for bulk tracing of elisp functions
Date: Sun, 11 Sep 2022 15:33:32 +0300 [thread overview]
Message-ID: <83y1uq850j.fsf@gnu.org> (raw)
In-Reply-To: <87leqqdtb4.fsf_-_@gnus.org> (message from Lars Ingebrigtsen on Sun, 11 Sep 2022 13:49:51 +0200)
> Cc: 1343@debbugs.gnu.org, 27397@debbugs.gnu.org,
> Michael Albinus <michael.albinus@gmx.de>, Dmitry Gutov <dgutov@yandex.ru>
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Sun, 11 Sep 2022 13:49:51 +0200
>
> Phil Sainty <psainty@orcon.net.nz> writes:
>
> > After a brief hiatus, I've resumed (maybe completed) my work on this.
> >
> > The branch scratch/bulk-tracing contains the updated code for Emacs 29
> > (rebased over master).
>
> For reference, I've included the diff between master and the branch
> below.
>
> I have not tried the patch myself -- does anybody have any comments
> here? It seems like useful functionality to me.
Yes, it is useful.
The documentation uses UK English spelling ("behaviour"). (Perhaps
today this is justified, but since a few days will have passed until
this is landed, I think we should use US English conventions
nonetheless.)
I see lack of important detail where stuff like 'context' and
'trace-value' is described: at the very least the manual should say
whether the text will be inserted verbatim, or with something like
newlines and/or other decorations added.
IMO, the description of trace-value should be before all the untrace-*
functions.
Why isn't trace-is-traceable-p documented in the manual? It sounds
relevant to the discussion of the restrictions.
I think the description should be updated fore native-compilation (it
only mentions byte-compilation).
The hunk from modes.texi seems unrelated.
The NEWS entry should have a single-line heading that is a full
sentence ending with a period.
Please verify that doc strings of functions mention all the
arguments. (E.g., trace-currently-traced doesn't.)
Thanks.
next prev parent reply other threads:[~2022-09-11 12:33 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 13:32 bug#27397: [PATCH] New commands for bulk tracing of elisp functions Phil Sainty
2017-06-16 14:58 ` Dmitry Gutov
2017-06-17 8:43 ` Phil Sainty
2017-06-17 9:13 ` Dmitry Gutov
2017-06-19 7:45 ` Michael Albinus
2017-06-19 9:35 ` Phil Sainty
2017-06-19 9:56 ` Michael Albinus
2017-06-19 11:00 ` Phil Sainty
2017-06-19 12:05 ` Michael Albinus
2017-06-19 12:17 ` Phil Sainty
2017-06-19 12:50 ` Dmitry Gutov
2017-06-19 13:07 ` Michael Albinus
2017-06-19 11:27 ` Dmitry Gutov
2017-06-19 11:36 ` Michael Albinus
2017-06-19 12:04 ` Dmitry Gutov
2017-06-19 12:08 ` Michael Albinus
2017-06-19 12:24 ` Phil Sainty
2017-06-16 15:43 ` Kaushal Modi
2017-06-17 8:48 ` Phil Sainty
2017-06-17 9:20 ` Phil Sainty
2017-06-17 12:31 ` Phil Sainty
2017-06-17 22:59 ` Dmitry Gutov
2017-06-18 1:06 ` Phil Sainty
2017-06-18 6:32 ` Dmitry Gutov
2017-06-18 11:22 ` Phil Sainty
2019-06-27 18:01 ` bug#1343: " Lars Ingebrigtsen
2019-06-28 11:25 ` bug#27397: " Phil Sainty
2021-04-17 5:51 ` bug#1343: [PATCH] trace package Stefan Kangas
2021-04-17 14:01 ` bug#27397: " Phil Sainty
2021-10-21 20:29 ` Stefan Kangas
2022-07-15 4:08 ` bug#27397: bug#1343: bug#27397: [PATCH] New commands for bulk tracing of elisp functions Phil Sainty
2022-07-15 6:23 ` Eli Zaretskii
2022-07-15 11:09 ` Phil Sainty
2022-09-11 11:49 ` Lars Ingebrigtsen
2022-09-11 12:33 ` Eli Zaretskii [this message]
2022-09-12 13:26 ` Michael Albinus
2022-09-12 22:17 ` bug#1343: " Phil Sainty
2022-09-13 7:34 ` bug#27397: " Michael Albinus
2022-09-13 11:11 ` Lars Ingebrigtsen
2017-06-17 23:03 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y1uq850j.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=1343@debbugs.gnu.org \
--cc=27397@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=larsi@gnus.org \
--cc=michael.albinus@gmx.de \
--cc=psainty@orcon.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).