From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#1343: bug#27397: [PATCH] New commands for bulk tracing of elisp functions Date: Sun, 11 Sep 2022 15:33:32 +0300 Message-ID: <83y1uq850j.fsf@gnu.org> References: <1348823a-7623-8146-8cc0-8c0eff13e458@orcon.net.nz> <94d27dbb-46d3-1d6f-4849-251a0929d413@orcon.net.nz> <70000e90-328c-c084-3e3c-bbde96b16110@orcon.net.nz> <6b195c26-066c-870f-3432-0b24c6f619ec@orcon.net.nz> <83fa3d61-9173-c3f6-32b6-87c7c09502b7@orcon.net.nz> <15f4e949736351f2d98fdee0b57e4d24@webmail.orcon.net.nz> <87leqqdtb4.fsf_-_@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31779"; mail-complaints-to="usenet@ciao.gmane.io" Cc: psainty@orcon.net.nz, 1343@debbugs.gnu.org, 27397@debbugs.gnu.org, michael.albinus@gmx.de, dgutov@yandex.ru To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 11 14:34:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXMAD-000869-NN for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Sep 2022 14:34:17 +0200 Original-Received: from localhost ([::1]:45496 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oXMAC-0006vD-JP for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Sep 2022 08:34:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51210) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXM9y-0006tC-Fq for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2022 08:34:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52373) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oXM9y-0005WS-6m for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2022 08:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oXM9y-0003WL-2r for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2022 08:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Sep 2022 12:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 1343 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch Original-Received: via spool by 1343-submit@debbugs.gnu.org id=B1343.166289963913524 (code B ref 1343); Sun, 11 Sep 2022 12:34:02 +0000 Original-Received: (at 1343) by debbugs.gnu.org; 11 Sep 2022 12:33:59 +0000 Original-Received: from localhost ([127.0.0.1]:41072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXM9v-0003Vy-8D for submit@debbugs.gnu.org; Sun, 11 Sep 2022 08:33:59 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXM9s-0003Ve-KW; Sun, 11 Sep 2022 08:33:57 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40390) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXM9m-0005Tx-Vh; Sun, 11 Sep 2022 08:33:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VjlQqvTPtgTQe48SHqWyP2qqPSCNcxaJTra9xENaa4E=; b=rjTFfW/msTc+ soOuP0kWmDgpziqZQwmNOysvINoHKkbuYDaai60JyfU7o/GPh17m4911FjfFpuqGgWd51TA0Togue fxHxZ7dzk1IGA9fycHafIqbCPeaUCearBX8VUWwx9lO/0WoS5SMPQ3Pd1nhpPSPFHAFZjzAlBuJ1a 2uG1RZ6NB7lwiT0WruJeDHmF7PEuSdwFELezuD15aNQ/SuVgo8PYemqraq/Pj/XI90qOrsMTGdV1k PUhCTJblLkcvCJiJZ2Xl1s4OpJgP0MiIsNUptgYCKFve+nJwMniFqXqv8XmmsL+bMZAZRgpw/vSaW fIrqtcpMz7WQ93m98drlyQ==; Original-Received: from [87.69.77.57] (port=2947 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXM9m-0003k4-6W; Sun, 11 Sep 2022 08:33:50 -0400 In-Reply-To: <87leqqdtb4.fsf_-_@gnus.org> (message from Lars Ingebrigtsen on Sun, 11 Sep 2022 13:49:51 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242164 Archived-At: > Cc: 1343@debbugs.gnu.org, 27397@debbugs.gnu.org, > Michael Albinus , Dmitry Gutov > From: Lars Ingebrigtsen > Date: Sun, 11 Sep 2022 13:49:51 +0200 > > Phil Sainty writes: > > > After a brief hiatus, I've resumed (maybe completed) my work on this. > > > > The branch scratch/bulk-tracing contains the updated code for Emacs 29 > > (rebased over master). > > For reference, I've included the diff between master and the branch > below. > > I have not tried the patch myself -- does anybody have any comments > here? It seems like useful functionality to me. Yes, it is useful. The documentation uses UK English spelling ("behaviour"). (Perhaps today this is justified, but since a few days will have passed until this is landed, I think we should use US English conventions nonetheless.) I see lack of important detail where stuff like 'context' and 'trace-value' is described: at the very least the manual should say whether the text will be inserted verbatim, or with something like newlines and/or other decorations added. IMO, the description of trace-value should be before all the untrace-* functions. Why isn't trace-is-traceable-p documented in the manual? It sounds relevant to the discussion of the restrictions. I think the description should be updated fore native-compilation (it only mentions byte-compilation). The hunk from modes.texi seems unrelated. The NEWS entry should have a single-line heading that is a full sentence ending with a period. Please verify that doc strings of functions mention all the arguments. (E.g., trace-currently-traced doesn't.) Thanks.