unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Phil Sainty <psainty@orcon.net.nz>
To: 27397@debbugs.gnu.org
Subject: bug#27397: [PATCH] New commands for bulk tracing of elisp functions
Date: Sat, 17 Jun 2017 21:20:00 +1200	[thread overview]
Message-ID: <94d27dbb-46d3-1d6f-4849-251a0929d413@orcon.net.nz> (raw)
In-Reply-To: <1348823a-7623-8146-8cc0-8c0eff13e458@orcon.net.nz>

Thanks to the merge with
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=1343 and
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=6464 I see that there
was a previous submission of a `trace-package' command which (a) used
foreground tracing, and (b) provided `trace-package-background' as a
separate command.

I should note that I elected not to support foreground tracing for
my proposed commands, simply because it seemed to me that foreground
tracing could be problematic in too many cases, when the traces are
being applied en masse on the basis of function name pattern matching.

The current `trace-function-foreground' docstring says:

> This function creates BUFFER if it does not exist.  This buffer will
> popup whenever FUNCTION is called.  Do not use this function to trace
> functions that switch buffers, or do any other display-oriented
> stuff - use ‘trace-function-background’ instead.

My compromise was to indicate the `trace-buffer' value in the echo
area when the commands are invoked, so that the user would know where
the trace output was happening.  Actually popping up that buffer when
the `trace-package' or `trace-regexp' command is used would be another
(perhaps nicer) option?

I'm open to recommendations for the most useful approach.

Do others think that foreground versions of these commands would be
a good idea?

A prefix argument could mean "use foreground tracing", but that's
inconsistent with `trace--read-args' which uses a prefix arg to prompt
the user for the trace buffer and a context expression -- which I now
realise is behaviour that my commands should incorporate as well.


-Phil





  parent reply	other threads:[~2017-06-17  9:20 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-16 13:32 bug#27397: [PATCH] New commands for bulk tracing of elisp functions Phil Sainty
2017-06-16 14:58 ` Dmitry Gutov
2017-06-17  8:43   ` Phil Sainty
2017-06-17  9:13     ` Dmitry Gutov
2017-06-19  7:45     ` Michael Albinus
2017-06-19  9:35       ` Phil Sainty
2017-06-19  9:56         ` Michael Albinus
2017-06-19 11:00           ` Phil Sainty
2017-06-19 12:05             ` Michael Albinus
2017-06-19 12:17               ` Phil Sainty
2017-06-19 12:50               ` Dmitry Gutov
2017-06-19 13:07                 ` Michael Albinus
2017-06-19 11:27           ` Dmitry Gutov
2017-06-19 11:36             ` Michael Albinus
2017-06-19 12:04               ` Dmitry Gutov
2017-06-19 12:08                 ` Michael Albinus
2017-06-19 12:24                 ` Phil Sainty
2017-06-16 15:43 ` Kaushal Modi
2017-06-17  8:48   ` Phil Sainty
2017-06-17  9:20 ` Phil Sainty [this message]
2017-06-17 12:31   ` Phil Sainty
2017-06-17 22:59     ` Dmitry Gutov
2017-06-18  1:06       ` Phil Sainty
2017-06-18  6:32         ` Dmitry Gutov
2017-06-18 11:22         ` Phil Sainty
2019-06-27 18:01           ` bug#1343: " Lars Ingebrigtsen
2019-06-28 11:25             ` bug#27397: " Phil Sainty
2021-04-17  5:51               ` bug#1343: [PATCH] trace package Stefan Kangas
2021-04-17 14:01                 ` bug#27397: " Phil Sainty
2021-10-21 20:29                   ` Stefan Kangas
2022-07-15  4:08               ` bug#27397: bug#1343: bug#27397: [PATCH] New commands for bulk tracing of elisp functions Phil Sainty
2022-07-15  6:23                 ` Eli Zaretskii
2022-07-15 11:09                   ` Phil Sainty
2022-09-11 11:49                 ` Lars Ingebrigtsen
2022-09-11 12:33                   ` Eli Zaretskii
2022-09-12 13:26                   ` Michael Albinus
2022-09-12 22:17                     ` bug#1343: " Phil Sainty
2022-09-13  7:34                       ` bug#27397: " Michael Albinus
2022-09-13 11:11                     ` Lars Ingebrigtsen
2017-06-17 23:03   ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94d27dbb-46d3-1d6f-4849-251a0929d413@orcon.net.nz \
    --to=psainty@orcon.net.nz \
    --cc=27397@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).