From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 57813@debbugs.gnu.org
Subject: bug#57813: Icon images are non-functional
Date: Mon, 19 Sep 2022 15:12:25 +0300 [thread overview]
Message-ID: <83y1ufy34m.fsf@gnu.org> (raw)
In-Reply-To: <86bkrcijsf.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 18 Sep 2022 22:06:56 +0300)
> From: Juri Linkov <juri@linkov.net>
> Cc: 57813@debbugs.gnu.org
> Date: Sun, 18 Sep 2022 22:06:56 +0300
>
> > Thanks. I only quickly read the patch, and have one comment: the
> > hard-coded left-margin should depend on the value returned by
> > current-bidi-paragraph-direction, because text that is displayed
> > right-to-left should have the icons on the right margin, not left
> > margin.
>
> To not create a new mirrored image file for RTL arrow required a change in
> icons--create to support ':rotation 180' for the existing image file:
>
> (define-icon outline-close-rtl-in-margins outline-close
> '((image "outline-close.svg" "outline-close.pbm"
> :height 10 :ascent center :rotation 180))
> "Icon used for buttons for closing a section in outline buffers."
> :version "29.1"
> :help-echo "Close this section")
>
> Then the right margin could be used with:
Thanks, the code LGTM.
next prev parent reply other threads:[~2022-09-19 12:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 19:40 bug#57813: Icon images are non-functional Juri Linkov
2022-09-15 16:30 ` Juri Linkov
2022-09-15 16:36 ` Juri Linkov
2022-09-15 16:53 ` Eli Zaretskii
2022-09-15 17:35 ` Juri Linkov
2022-09-15 18:32 ` Eli Zaretskii
2022-09-15 19:46 ` Juri Linkov
2022-09-16 16:16 ` Juri Linkov
2022-09-15 19:53 ` Juri Linkov
2022-09-16 5:29 ` Eli Zaretskii
2022-09-16 7:09 ` Juri Linkov
2022-09-17 19:37 ` Juri Linkov
2022-09-18 5:08 ` Eli Zaretskii
2022-09-18 18:46 ` Juri Linkov
2022-09-18 5:17 ` Eli Zaretskii
2022-09-18 19:06 ` Juri Linkov
2022-09-19 12:12 ` Eli Zaretskii [this message]
2022-09-19 19:37 ` Juri Linkov
2022-09-20 11:31 ` Eli Zaretskii
2022-09-20 16:12 ` Juri Linkov
2022-09-23 15:48 ` Juri Linkov
2022-09-23 16:26 ` Lars Ingebrigtsen
2022-09-24 17:17 ` Juri Linkov
2022-10-12 14:42 ` Max Brieiev
2022-10-12 18:55 ` Juri Linkov
2022-10-23 16:55 ` Juri Linkov
2022-10-13 7:51 ` Juri Linkov
2022-10-18 18:14 ` Juri Linkov
2022-10-18 18:35 ` Juri Linkov
2022-10-19 6:44 ` Juri Linkov
2022-10-22 18:38 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y1ufy34m.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=57813@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).