unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 57813@debbugs.gnu.org
Subject: bug#57813: Icon images are non-functional
Date: Thu, 15 Sep 2022 22:46:56 +0300	[thread overview]
Message-ID: <86h718774f.fsf@mail.linkov.net> (raw)
In-Reply-To: <835yhozdwl.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 15 Sep 2022 21:32:58 +0300")

>>   With something like:
>>
>>   (setq outline-minor-mode-use-buttons '(derived-mode . special-mode))
>
> I still cannot reproduce this, after evaluating the above and visiting
> NEWS.  Neither do I see buttons in NEWS.  What else is needed?  Can
> you show a recipe starting from "emacs -Q"?

1. Eval: (setq outline-minor-mode-use-buttons '(derived-mode . special-mode))
2. Type 'C-h n'.
3. 'S-TAB' on a heading.

> And if you load outline.el (not .elc or .eln)?  How does the profile
> before optimization look then?

        5236  87% - command-execute
        5178  86%  - funcall-interactively
        5166  86%   - outline-cycle-buffer
        5166  86%    - let
        5166  86%     - outline--fix-up-all-buttons
        5166  86%      - if
        5166  86%       - progn
        5166  86%        - outline-map-region
        5166  86%         - save-excursion
        5166  86%          - if
        5166  86%           - progn
        5162  86%            - while
        5150  86%             - funcall
        5150  86%              - #<lambda 0x1c5f63c054af8dba>
        5150  86%               - if
        5142  86%                - eq
        5142  86%                 - condition-case
        5142  86%                  - progn
        5142  86%                   - outline--cycle-state
        5138  86%                    - save-excursion
        5138  86%                     - let
        3718  62%                      + outline-back-to-heading
         824  13%                      + outline-end-of-subtree
         314   5%                      + cond
         274   4%                      + setq
           8   0%                      + outline-end-of-heading

The patch removes the problematic outline-back-to-heading and
outline-end-of-subtree.





  reply	other threads:[~2022-09-15 19:46 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-14 19:40 bug#57813: Icon images are non-functional Juri Linkov
2022-09-15 16:30 ` Juri Linkov
2022-09-15 16:36   ` Juri Linkov
2022-09-15 16:53     ` Eli Zaretskii
2022-09-15 17:35       ` Juri Linkov
2022-09-15 18:32         ` Eli Zaretskii
2022-09-15 19:46           ` Juri Linkov [this message]
2022-09-16 16:16             ` Juri Linkov
2022-09-15 19:53   ` Juri Linkov
2022-09-16  5:29     ` Eli Zaretskii
2022-09-16  7:09       ` Juri Linkov
2022-09-17 19:37         ` Juri Linkov
2022-09-18  5:08           ` Eli Zaretskii
2022-09-18 18:46             ` Juri Linkov
2022-09-18  5:17           ` Eli Zaretskii
2022-09-18 19:06             ` Juri Linkov
2022-09-19 12:12               ` Eli Zaretskii
2022-09-19 19:37                 ` Juri Linkov
2022-09-20 11:31                   ` Eli Zaretskii
2022-09-20 16:12                     ` Juri Linkov
2022-09-23 15:48     ` Juri Linkov
2022-09-23 16:26       ` Lars Ingebrigtsen
2022-09-24 17:17         ` Juri Linkov
2022-10-12 14:42           ` Max Brieiev
2022-10-12 18:55             ` Juri Linkov
2022-10-23 16:55               ` Juri Linkov
2022-10-13  7:51 ` Juri Linkov
2022-10-18 18:14   ` Juri Linkov
2022-10-18 18:35     ` Juri Linkov
2022-10-19  6:44       ` Juri Linkov
2022-10-22 18:38         ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86h718774f.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=57813@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).