From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#57813: Icon images are non-functional Date: Mon, 19 Sep 2022 15:12:25 +0300 Message-ID: <83y1ufy34m.fsf@gnu.org> References: <86pmfxlp7s.fsf@mail.linkov.net> <861qsca9cn.fsf@mail.linkov.net> <867d2476u4.fsf@mail.linkov.net> <831qsb6g69.fsf@gnu.org> <86illnpzgh.fsf@mail.linkov.net> <86mtaxaj2l.fsf@mail.linkov.net> <83sfkpz2gb.fsf@gnu.org> <86bkrcijsf.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13834"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57813@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 19 14:13:42 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaFee-0003RS-PK for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Sep 2022 14:13:40 +0200 Original-Received: from localhost ([::1]:46328 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oaFed-0000Ve-A0 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Sep 2022 08:13:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48708) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oaFe3-0000VO-TW for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 08:13:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53539) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oaFe2-0001SA-0Z for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 08:13:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oaFe1-0004UJ-RS for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 08:13:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Sep 2022 12:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57813 X-GNU-PR-Package: emacs Original-Received: via spool by 57813-submit@debbugs.gnu.org id=B57813.166358955217209 (code B ref 57813); Mon, 19 Sep 2022 12:13:01 +0000 Original-Received: (at 57813) by debbugs.gnu.org; 19 Sep 2022 12:12:32 +0000 Original-Received: from localhost ([127.0.0.1]:52617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaFdX-0004TV-NB for submit@debbugs.gnu.org; Mon, 19 Sep 2022 08:12:31 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaFdV-0004TI-FC for 57813@debbugs.gnu.org; Mon, 19 Sep 2022 08:12:29 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52784) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oaFdP-0001IH-Ie; Mon, 19 Sep 2022 08:12:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Q1lSsfcKdpWdaviPRx45nXcS6WFmA+w6izY781yM714=; b=SImJYbv9vgAa oXdEE8MW39WFzxIcn+Nl7Y8BL8mgPt7IXVQ6zW+KrWvFNLpWPwKqNR3Z6BwFHPTSvhtyM5xSW/RH1 oZxaUxhKvHANgaKYZLUFhVtub6HLm4vC3FJi3jDL8MT/3CPl0cN/DDUn3dnlVPPlH+rhcCd4W+7Gu TWOzrEK+zLsGL3As/KHZbe03W8DAYDMsiNhCPVk7zOKv/ZMEx7IJDMi+5Ma8uIG0zXqX55CGxxagv QbYaqg5u3GWxcYGQVJqd6aRNe5PnexmQZUSsTw9du0OpKNfXrwfZrjxyQ3tuN0SUBZRtmrZPtCwF4 bg11WhxYItXobJEOHqCoqw==; Original-Received: from [87.69.77.57] (port=4082 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oaFdN-0006f4-3X; Mon, 19 Sep 2022 08:12:21 -0400 In-Reply-To: <86bkrcijsf.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 18 Sep 2022 22:06:56 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243073 Archived-At: > From: Juri Linkov > Cc: 57813@debbugs.gnu.org > Date: Sun, 18 Sep 2022 22:06:56 +0300 > > > Thanks. I only quickly read the patch, and have one comment: the > > hard-coded left-margin should depend on the value returned by > > current-bidi-paragraph-direction, because text that is displayed > > right-to-left should have the icons on the right margin, not left > > margin. > > To not create a new mirrored image file for RTL arrow required a change in > icons--create to support ':rotation 180' for the existing image file: > > (define-icon outline-close-rtl-in-margins outline-close > '((image "outline-close.svg" "outline-close.pbm" > :height 10 :ascent center :rotation 180)) > "Icon used for buttons for closing a section in outline buffers." > :version "29.1" > :help-echo "Close this section") > > Then the right margin could be used with: Thanks, the code LGTM.