unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Yuan Fu <casouri@gmail.com>
Cc: 64442@debbugs.gnu.org
Subject: bug#64442: 29.0.92; treesit-beginning-of-defun fails in DEFUN functions in C
Date: Thu, 17 Aug 2023 11:18:22 +0300	[thread overview]
Message-ID: <83wmxu5bg1.fsf@gnu.org> (raw)
In-Reply-To: <5B9E9ADF-C632-475B-8D68-3BF0275279E5@gmail.com> (message from Yuan Fu on Tue, 15 Aug 2023 00:30:53 -0700)

> From: Yuan Fu <casouri@gmail.com>
> Date: Tue, 15 Aug 2023 00:30:53 -0700
> Cc: 64442@debbugs.gnu.org
> 
> >>> That would allow "C-x 4 a" to work inside a DEFUN,
> >>> something that still works less reliably with this patch: you must be
> >>> in the "first defun" to get it to find the name of the function.
> >> 
> >> C-x 4 a should’ve been fixed already. And it shouldn’t rely on this fix to work. Do you have a recipe for when it doesn’t work?
> > 
> > Just try it with your patch.  If point is inside the body, the
> > function's name is not captured by "C-x 4 a”.
> 
> My bad, I must’ve been trying C-x 4 a in a different Emacs session, which worked. Anyway, I updated the patch and C-x 4 a should now work.

Thanks, LGTM.  Please install on the emacs-29 branch, and close the
bug when you do.





  reply	other threads:[~2023-08-17  8:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-03 17:13 bug#64442: 29.0.92; treesit-beginning-of-defun fails in DEFUN functions in C Eli Zaretskii
2023-07-04  8:41 ` Yuan Fu
2023-07-04 11:39   ` Eli Zaretskii
2023-07-07  6:15     ` Yuan Fu
2023-07-07  6:40       ` Eli Zaretskii
2023-07-12  2:10         ` Yuan Fu
2023-07-30  7:10           ` Eli Zaretskii
2023-08-10  9:18             ` Eli Zaretskii
2023-08-10 21:33               ` Yuan Fu
2023-08-12 14:59                 ` Eli Zaretskii
2023-08-14  5:20                   ` Yuan Fu
2023-08-14 11:59                     ` Eli Zaretskii
2023-08-15  7:30                       ` Yuan Fu
2023-08-17  8:18                         ` Eli Zaretskii [this message]
2023-08-19 22:00 ` Yuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wmxu5bg1.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=64442@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).