From: Yuan Fu <casouri@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 64442@debbugs.gnu.org
Subject: bug#64442: 29.0.92; treesit-beginning-of-defun fails in DEFUN functions in C
Date: Thu, 6 Jul 2023 23:15:00 -0700 [thread overview]
Message-ID: <DD7A98E1-0AFF-4CDC-9BFD-88DDABB80CAA@gmail.com> (raw)
In-Reply-To: <83pm57lxbo.fsf@gnu.org>
> On Jul 4, 2023, at 4:39 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> From: Yuan Fu <casouri@gmail.com>
>> Date: Tue, 4 Jul 2023 01:41:22 -0700
>> Cc: 64442@debbugs.gnu.org
>>
>> The problem with DEFUN’s is that a DEFUN is really made of two nodes in the parse tree. One for the DEFUN part, one for the body, and there isn’t a parent node that encloses the two.
>>
>> The defun movement functions are not designed to handle a construct made of two adjacent nodes. They can find a node, go to the beginning/end of it; they can’t find a node, and go to the end of the next node.
>>
>> It sounds easy to add some hack to handle it, but really isn’t. Defun movement need to support forward/backward to beg/end, that’s four movement types;
>
> Why cannot we look for a top-level expression_statement node which is
> a call_expression whose function identifier is "DEFUN" and whose
> position is between the place where C-M-a was invoked and the place
> where it does find a defun?
It’s gonna be ugly, but I can take a jab at it this weekend. I’m thinking of a wrapper function that tries to detect DEFUN before falling back to the ordinary tree-sitter defun movement function.
>
>> on top of that you have nested defun’s.
>
> DEFUN's cannot be nested, so we don't need to consider that.
Yeah, in general C sources don’t have nested defuns, only C++ ones do. I was trying to illustrate that it’s hard to extend existing defun movement framework such that it handles this special case. The best solution I can think of is what I described above.
Yuan
next prev parent reply other threads:[~2023-07-07 6:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 17:13 bug#64442: 29.0.92; treesit-beginning-of-defun fails in DEFUN functions in C Eli Zaretskii
2023-07-04 8:41 ` Yuan Fu
2023-07-04 11:39 ` Eli Zaretskii
2023-07-07 6:15 ` Yuan Fu [this message]
2023-07-07 6:40 ` Eli Zaretskii
2023-07-12 2:10 ` Yuan Fu
2023-07-30 7:10 ` Eli Zaretskii
2023-08-10 9:18 ` Eli Zaretskii
2023-08-10 21:33 ` Yuan Fu
2023-08-12 14:59 ` Eli Zaretskii
2023-08-14 5:20 ` Yuan Fu
2023-08-14 11:59 ` Eli Zaretskii
2023-08-15 7:30 ` Yuan Fu
2023-08-17 8:18 ` Eli Zaretskii
2023-08-19 22:00 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DD7A98E1-0AFF-4CDC-9BFD-88DDABB80CAA@gmail.com \
--to=casouri@gmail.com \
--cc=64442@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).