From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64442: 29.0.92; treesit-beginning-of-defun fails in DEFUN functions in C Date: Thu, 17 Aug 2023 11:18:22 +0300 Message-ID: <83wmxu5bg1.fsf@gnu.org> References: <83a5wcncj8.fsf@gnu.org> <83pm57lxbo.fsf@gnu.org> <835y6wgr77.fsf@gnu.org> <93E5B9EA-D349-4316-B314-D6994329C261@gmail.com> <83r0oplvro.fsf@gnu.org> <83y1iji7b7.fsf@gnu.org> <2134730B-05A4-4032-84B6-42FD3CDC48AE@gmail.com> <83a5uwe27a.fsf@gnu.org> <5EA1F5AD-C6C4-4838-8265-5A7ECF69041D@gmail.com> <83jztxbzsp.fsf@gnu.org> <5B9E9ADF-C632-475B-8D68-3BF0275279E5@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39032"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64442@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 17 10:19:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qWYE1-0009w6-Kl for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Aug 2023 10:19:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qWYDk-0002Pg-Ql; Thu, 17 Aug 2023 04:19:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWYDg-0002No-H2 for bug-gnu-emacs@gnu.org; Thu, 17 Aug 2023 04:19:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qWYDe-0002Zh-If for bug-gnu-emacs@gnu.org; Thu, 17 Aug 2023 04:19:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qWYDe-0006gK-CM for bug-gnu-emacs@gnu.org; Thu, 17 Aug 2023 04:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Aug 2023 08:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64442 X-GNU-PR-Package: emacs Original-Received: via spool by 64442-submit@debbugs.gnu.org id=B64442.169226030425640 (code B ref 64442); Thu, 17 Aug 2023 08:19:02 +0000 Original-Received: (at 64442) by debbugs.gnu.org; 17 Aug 2023 08:18:24 +0000 Original-Received: from localhost ([127.0.0.1]:42731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWYD2-0006fU-AX for submit@debbugs.gnu.org; Thu, 17 Aug 2023 04:18:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWYD1-0006fH-GF for 64442@debbugs.gnu.org; Thu, 17 Aug 2023 04:18:23 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWYCw-00011y-2G; Thu, 17 Aug 2023 04:18:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=gEH1m/QU3XT6izZD0d0bQM5WlNsHI8Ux/y4cmdJpG/g=; b=RZ9u6r1uFT5+wFgDHBS+ 0toNK4j07bgvcDvkJ+4sgcoW9awPC9zTnQpsd+5udqnlfHL/Owe7ojlZDzzANeqzbmIu0sxDCTOBV nReWA3zPoqttpsvsM8llPaPiyQNdRaltQZInU/GTYTwWloZo+jLmpusR9WFttKNKDGpxynDHQptkD Odv4615SpOr5Bmbo0X5iGh9Hr7p5aSdqD+El4HKOL+P3ypaA1c4B62ZOBvV3AFUSLDLsSJWUdS6Ot iN8SgK54FHmdtqXr+cCk/zNviEJmqjlQs584QpAxFCPoNjqi9+mU7kS4zQ1SfzeXPdvW2KB9C44wx dtJnbGhP7+jmXQ==; In-Reply-To: <5B9E9ADF-C632-475B-8D68-3BF0275279E5@gmail.com> (message from Yuan Fu on Tue, 15 Aug 2023 00:30:53 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267644 Archived-At: > From: Yuan Fu > Date: Tue, 15 Aug 2023 00:30:53 -0700 > Cc: 64442@debbugs.gnu.org > > >>> That would allow "C-x 4 a" to work inside a DEFUN, > >>> something that still works less reliably with this patch: you must be > >>> in the "first defun" to get it to find the name of the function. > >> > >> C-x 4 a should’ve been fixed already. And it shouldn’t rely on this fix to work. Do you have a recipe for when it doesn’t work? > > > > Just try it with your patch. If point is inside the body, the > > function's name is not captured by "C-x 4 a”. > > My bad, I must’ve been trying C-x 4 a in a different Emacs session, which worked. Anyway, I updated the patch and C-x 4 a should now work. Thanks, LGTM. Please install on the emacs-29 branch, and close the bug when you do.