unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Bob Rogers <rogers@rgrjr.com>
Cc: 54133-done@debbugs.gnu.org
Subject: bug#54133: 29.0.50; Buffer-menu-visit-tags-table disrupts non-tags buffers
Date: Thu, 24 Feb 2022 22:00:30 +0200	[thread overview]
Message-ID: <83v8x4qbkx.fsf@gnu.org> (raw)
In-Reply-To: <25111.51264.11851.407727@orion.rgrjr.com> (message from Bob Rogers on Thu, 24 Feb 2022 13:02:40 -0500)

> From: Bob Rogers <rogers@rgrjr.com>
> Date: Thu, 24 Feb 2022 13:02:40 -0500
> CC: 54133@debbugs.gnu.org
> 
>    Maybe we should have a more thorough implementation in
>    etags-verify-tags-table, then.  But that function's purpose is to do
>    what we need here.
> 
> That would require disentangling detection and initialization.  Which
> shouldn't be all that hard; it just seemed like more work than necessary
> to scratch this particular itch.
> 
>    > In short, I thought checking the major mode was the better choice,
>    > since the file was already present in a buffer.
> 
>    But what if the file is already in a buffer, but not under the right
>    major-mode?  E.g., what if the file was visited literally?
> 
> Ah, so you mean that Buffer-menu-visit-tags-table is normally meant to
> introduce tags-table-mode in buffers not already there.  I see now that
> is implied by "Visit the tags table ..." in the command documentation.
> In which case I withdraw my reservations.

Thanks, I installed the changes, and I'm marking this bug done.

>    And maybe I'll have a look at cleaning up etags initialization when I
> get a chance . . .

TIA.





      reply	other threads:[~2022-02-24 20:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-23 21:37 bug#54133: 29.0.50; Buffer-menu-visit-tags-table disrupts non-tags buffers Bob Rogers
2022-02-24  9:19 ` martin rudalics
2022-02-24 15:15 ` Eli Zaretskii
2022-02-24 17:30   ` Bob Rogers
2022-02-24 17:42     ` Eli Zaretskii
2022-02-24 18:02       ` Bob Rogers
2022-02-24 20:00         ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83v8x4qbkx.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=54133-done@debbugs.gnu.org \
    --cc=rogers@rgrjr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).