From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#54133: 29.0.50; Buffer-menu-visit-tags-table disrupts non-tags buffers Date: Thu, 24 Feb 2022 22:00:30 +0200 Message-ID: <83v8x4qbkx.fsf@gnu.org> References: <25110.43271.146078.920965@orion.rgrjr.com> <8335k8s3bp.fsf@gnu.org> <25111.49357.417530.307552@orion.rgrjr.com> <83zgmgqhzd.fsf@gnu.org> <25111.51264.11851.407727@orion.rgrjr.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15778"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54133-done@debbugs.gnu.org To: Bob Rogers Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 24 21:03:07 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nNKKQ-0003tk-V1 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Feb 2022 21:03:07 +0100 Original-Received: from localhost ([::1]:58744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nNKKP-0007Ca-6G for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Feb 2022 15:03:05 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42260) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNKIR-000567-0O for bug-gnu-emacs@gnu.org; Thu, 24 Feb 2022 15:01:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56583) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nNKIQ-0000J6-Lc for bug-gnu-emacs@gnu.org; Thu, 24 Feb 2022 15:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nNKIQ-00024i-I9 for bug-gnu-emacs@gnu.org; Thu, 24 Feb 2022 15:01:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Feb 2022 20:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 54133 X-GNU-PR-Package: emacs Mail-Followup-To: 54133@debbugs.gnu.org, eliz@gnu.org, rogers@rgrjr.com Original-Received: via spool by 54133-done@debbugs.gnu.org id=D54133.16457328307924 (code D ref 54133); Thu, 24 Feb 2022 20:01:02 +0000 Original-Received: (at 54133-done) by debbugs.gnu.org; 24 Feb 2022 20:00:30 +0000 Original-Received: from localhost ([127.0.0.1]:50479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNKHu-00023k-8b for submit@debbugs.gnu.org; Thu, 24 Feb 2022 15:00:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNKHs-00023X-Ry for 54133-done@debbugs.gnu.org; Thu, 24 Feb 2022 15:00:29 -0500 Original-Received: from [2001:470:142:3::e] (port=50584 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNKHn-0000A7-F5; Thu, 24 Feb 2022 15:00:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Kg29+iTsC7afIfTbQ1EkQWzZTGbdU8fpeTe5Tuh8bM4=; b=Sij8ZNpzFwIQ b4fIAAYl/p9Tv7KlrxjogJAfKkmQNX4idjJokTDveZagD9fHXduIVwK5fmCVA16ENP/pdCBdO6tH9 23ALHktdVmdsCvmLMXCon6UoPTXdITOfo8+GYscbVf5OQKW4cCfy35FM0WLr2mljjj8j1gVpdYi8l Fe5JKrqfrYUhBdKbSqkHgQoIl75xbeyKwmYpx5czb+RD2RFj/BpC/hwuDQJw9h//0GKpHXnxh/8KX G/if+xjltGXFWyTmSfGt5qKZsPqBzQLgbeON4AjhmkHQ20WJHI9J9aV2BjmJtvmGP6vuy6+Ic8X8A qBzGdoTe/sD3ht7nSi0G+w==; Original-Received: from [87.69.77.57] (port=3825 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNKHm-0005AO-Pw; Thu, 24 Feb 2022 15:00:23 -0500 In-Reply-To: <25111.51264.11851.407727@orion.rgrjr.com> (message from Bob Rogers on Thu, 24 Feb 2022 13:02:40 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227597 Archived-At: > From: Bob Rogers > Date: Thu, 24 Feb 2022 13:02:40 -0500 > CC: 54133@debbugs.gnu.org > > Maybe we should have a more thorough implementation in > etags-verify-tags-table, then. But that function's purpose is to do > what we need here. > > That would require disentangling detection and initialization. Which > shouldn't be all that hard; it just seemed like more work than necessary > to scratch this particular itch. > > > In short, I thought checking the major mode was the better choice, > > since the file was already present in a buffer. > > But what if the file is already in a buffer, but not under the right > major-mode? E.g., what if the file was visited literally? > > Ah, so you mean that Buffer-menu-visit-tags-table is normally meant to > introduce tags-table-mode in buffers not already there. I see now that > is implied by "Visit the tags table ..." in the command documentation. > In which case I withdraw my reservations. Thanks, I installed the changes, and I'm marking this bug done. > And maybe I'll have a look at cleaning up etags initialization when I > get a chance . . . TIA.