From: Eli Zaretskii <eliz@gnu.org>
To: Bob Rogers <rogers@rgrjr.com>
Cc: 54133@debbugs.gnu.org
Subject: bug#54133: 29.0.50; Buffer-menu-visit-tags-table disrupts non-tags buffers
Date: Thu, 24 Feb 2022 19:42:14 +0200 [thread overview]
Message-ID: <83zgmgqhzd.fsf@gnu.org> (raw)
In-Reply-To: <25111.49357.417530.307552@orion.rgrjr.com> (message from Bob Rogers on Thu, 24 Feb 2022 12:30:53 -0500)
> From: Bob Rogers <rogers@rgrjr.com>
> Date: Thu, 24 Feb 2022 12:30:53 -0500
> Cc: 54133@debbugs.gnu.org
>
> From: Eli Zaretskii <eliz@gnu.org>
> Date: Thu, 24 Feb 2022 17:15:54 +0200
>
> > From: Bob Rogers <rogers@rgrjr.com>
> > Date: Wed, 23 Feb 2022 16:37:11 -0500
> >
> > . . .
> >
> > The real problem is that visit-tags-table assumes that the user knows
> > what they're doing, and makes these irreversible changes before being
> > sure of having a valid tags table. That would be a harder thing to fix,
> > though -- and might not deal as well with my buffer-menu typos. ;-}
>
> Does the alternative patch below give good results?
>
> This does ineed work, and I had considered something similar, but was
> concerned that it would not be as robust. etags-verify-tags-table is
> called from etags-recognize-tags-table, which is only a part of the
> tags-table-format-functions extension mechanism used by
> initialize-new-tags-table. So to avoid breaking this mechanism I would
> either have had to call initialize-new-tags-table and have it possibly
> set unwanted local variables, or delve more deeply into the internals by
> running tags-table-format-functions myself.
Maybe we should have a more thorough implementation in
etags-verify-tags-table, then. But that function's purpose is to do
what we need here.
> In short, I thought checking the major mode was the better choice,
> since the file was already present in a buffer.
But what if the file is already in a buffer, but not under the right
major-mode? E.g., what if the file was visited literally?
next prev parent reply other threads:[~2022-02-24 17:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 21:37 bug#54133: 29.0.50; Buffer-menu-visit-tags-table disrupts non-tags buffers Bob Rogers
2022-02-24 9:19 ` martin rudalics
2022-02-24 15:15 ` Eli Zaretskii
2022-02-24 17:30 ` Bob Rogers
2022-02-24 17:42 ` Eli Zaretskii [this message]
2022-02-24 18:02 ` Bob Rogers
2022-02-24 20:00 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zgmgqhzd.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=54133@debbugs.gnu.org \
--cc=rogers@rgrjr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).