From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: rudalics@gmx.at, 55696@debbugs.gnu.org, jeff.kowalski@gmail.com
Subject: bug#55696: 28.1; eshell fails to respect text-scale-increase
Date: Sun, 05 Jun 2022 22:00:24 +0300 [thread overview]
Message-ID: <83sfoj7x6f.fsf@gnu.org> (raw)
In-Reply-To: <34062848-8fe4-351c-df63-5cc341fefa57@gmail.com> (message from Jim Porter on Sun, 5 Jun 2022 11:12:50 -0700)
> Cc: 55696@debbugs.gnu.org, jeff.kowalski@gmail.com
> From: Jim Porter <jporterbugs@gmail.com>
> Date: Sun, 5 Jun 2022 11:12:50 -0700
>
> > I think we should optimize the frequent case where
> > Vface_remapping_alist is nil, in which case BODY_IN_REMAPPED_CHARS is
> > the same as BODY_IN_CANONICAL_CHARS. lookup_named_face is not a
> > trivial function, so it is best to avoid calling it whenever possible.
>
> Good point. How does the updated implementation look?
Looks okay, except for one thing:
> + if (pixelwise == BODY_IN_REMAPPED_CHARS)
> + {
> + if (Vface_remapping_alist)
This should be
if (!NILP (Vface_remapping_alist))
because the implementation of nil is not necessarily an integer zero.
You will get compilation errors if you configure with the
"--enable-check-lisp-object-type" option.
I will do a more thorough review tomorrow.
next prev parent reply other threads:[~2022-06-05 19:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-29 3:43 bug#55696: 28.1; eshell fails to respect text-scale-increase Jeff Kowalski
2022-06-03 4:41 ` Jim Porter
2022-06-03 6:31 ` Eli Zaretskii
2022-06-03 20:30 ` Jim Porter
2022-06-04 6:20 ` Eli Zaretskii
2022-06-05 4:49 ` Jim Porter
2022-06-05 9:13 ` Eli Zaretskii
2022-06-05 18:12 ` Jim Porter
2022-06-05 19:00 ` Eli Zaretskii [this message]
2022-06-05 19:59 ` Jim Porter
2022-06-06 12:43 ` Eli Zaretskii
2022-06-07 3:04 ` Jim Porter
2022-06-07 10:55 ` Eli Zaretskii
2022-06-08 8:07 ` martin rudalics
2022-06-08 23:20 ` Jim Porter
2022-06-09 7:24 ` Eli Zaretskii
2022-06-09 15:55 ` Jim Porter
2022-06-09 16:48 ` Eli Zaretskii
2022-06-09 22:14 ` Jim Porter
2022-06-10 5:52 ` Eli Zaretskii
2022-06-10 15:44 ` Jim Porter
2022-06-10 15:58 ` Eli Zaretskii
2022-06-10 16:44 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sfoj7x6f.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=55696@debbugs.gnu.org \
--cc=jeff.kowalski@gmail.com \
--cc=jporterbugs@gmail.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).