From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 55696@debbugs.gnu.org, jeff.kowalski@gmail.com
Subject: bug#55696: 28.1; eshell fails to respect text-scale-increase
Date: Thu, 09 Jun 2022 19:48:28 +0300 [thread overview]
Message-ID: <837d5p3hr7.fsf@gnu.org> (raw)
In-Reply-To: <4abda9a0-7c34-cdad-fc9e-a6dc25e7c74b@gmail.com> (message from Jim Porter on Thu, 9 Jun 2022 08:55:36 -0700)
> From: Jim Porter <jporterbugs@gmail.com>
> Date: Thu, 9 Jun 2022 08:55:36 -0700
>
> Do the tests work if you replace "list" in those two functions with
> "listify"? (`eshell/listify' is a built-in Eshell alias function, which
> is the highest priority for Eshell commands, so it should always work.)
If I make this replacement in 4 tests that use "list", then it doesn't
hang, but 2 tests fail:
Test esh-var-test/interp-lisp-indices backtrace:
(listify 1 2)
eval((listify 1 2))
eshell-exec-lisp(eshell-print eshell-error (listify 1 2) nil t)
eshell-lisp-command((listify 1 2))
eval((eshell-lisp-command '(listify 1 2)))
eshell-do-eval((eshell-lisp-command '(listify 1 2)) t)
eshell-do-eval((progn (eshell-lisp-command '(listify 1 2)) (symbol-v
#f(compiled-function () #<bytecode -0x12ccc80303566d4e>)()
funcall(#f(compiled-function () #<bytecode -0x12ccc80303566d4e>))
(let ((eshell-current-handles '[nil (eshell-temp . 1) (eshell-temp .
eval((let ((eshell-current-handles '[nil (eshell-temp . 1) (eshell-t
eshell-do-eval((let ((eshell-current-handles '[nil (eshell-temp . 1)
#f(compiled-function () #<bytecode -0x12ccc80303566d4e>)()
funcall(#f(compiled-function () #<bytecode -0x12ccc80303566d4e>))
(let ((value 'eshell-temp) (eshell-in-pipeline-p 'nil)) (funcall '#f
eval((let ((value 'eshell-temp) (eshell-in-pipeline-p 'nil)) (funcal
eshell-do-eval((let ((value 'eshell-temp) (eshell-in-pipeline-p 'nil
eshell-do-eval((eshell-apply-indices (let ((value 'eshell-temp) (esh
#f(compiled-function () #<bytecode -0x12ccc80303566d4e>)()
funcall(#f(compiled-function () #<bytecode -0x12ccc80303566d4e>))
(let ((indices '((#("1" 0 1 (number t)))))) (funcall '#f(compiled-fu
eval((let ((indices '((#("1" 0 1 ...))))) (funcall '#f(compiled-func
eshell-do-eval((let ((indices '((#("1" 0 1 ...))))) (eshell-apply-in
eshell-do-eval((eshell-escape-arg (let ((indices '((...)))) (eshell-
eshell-do-eval((list (eshell-escape-arg (let ((indices '(...))) (esh
eshell-do-eval((eshell-named-command '"+" (list (eshell-escape-arg (
eshell-do-eval((prog1 (eshell-named-command '"+" (list (eshell-escap
(condition-case err (eshell-do-eval '(prog1 (eshell-named-command '"
eval((condition-case err (eshell-do-eval '(prog1 (eshell-named-comma
eshell-do-eval((condition-case err (eshell-do-eval '(prog1 (eshell-n
#f(compiled-function () #<bytecode -0x12ccc80303566d4e>)()
funcall(#f(compiled-function () #<bytecode -0x12ccc80303566d4e>))
(let ((eshell-this-command-hook '(ignore))) (funcall '#f(compiled-fu
eval((let ((eshell-this-command-hook '(ignore))) (funcall '#f(compil
eshell-do-eval((let ((eshell-this-command-hook '(ignore))) (conditio
eshell-do-eval((progn (let ((eshell-this-command-hook '(ignore))) (c
#f(compiled-function () #<bytecode -0x12ccc80303566d4e>)()
funcall(#f(compiled-function () #<bytecode -0x12ccc80303566d4e>))
(let ((eshell-current-handles '[nil (eshell-temp . 1) (eshell-temp .
eval((let ((eshell-current-handles '[nil (eshell-temp . 1) (eshell-t
eshell-do-eval((let ((eshell-current-handles '[nil (eshell-temp . 1)
#f(compiled-function () #<bytecode -0x12ccc80303566d4e>)()
funcall(#f(compiled-function () #<bytecode -0x12ccc80303566d4e>))
(let ((value 'eshell-temp) (eshell-in-pipeline-p 'nil)) (funcall '#f
eval((let ((value 'eshell-temp) (eshell-in-pipeline-p 'nil)) (funcal
eshell-do-eval((let ((value 'eshell-temp) (eshell-in-pipeline-p 'nil
#f(compiled-function () #<bytecode -0x12ccc80303566d4e>)()
funcall(#f(compiled-function () #<bytecode -0x12ccc80303566d4e>))
(let ((eshell-current-handles '[nil (t . 1) (t . 1)]) (eshell-curren
eval((let ((eshell-current-handles '[nil (t . 1) (t . 1)]) (eshell-c
eshell-do-eval((let ((eshell-current-handles '[nil (t . 1) (t . 1)])
eshell-command-result("+ $(listify 1 2)[1] 3")
(let ((eshell-history-file-name nil)) (eshell-command-result command
(progn (let ((eshell-history-file-name nil)) (eshell-command-result
(unwind-protect (progn (let ((eshell-history-file-name nil)) (eshell
(let* ((coding-system-for-write nil) (temp-file (file-name-as-direct
eshell-test-command-result("+ $(listify 1 2)[1] 3")
(list (eshell-test-command-result "+ $(listify 1 2)[1] 3") 5)
(let ((signal-hook-function #'ert--should-signal-hook)) (list (eshel
(condition-case err (let ((signal-hook-function #'ert--should-signal
(let* ((fn-140 #'equal) (args-141 (condition-case err (let ((signal-
(closure (t) nil (let* ((fn-140 #'equal) (args-141 (condition-case e
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name esh-var-test/interp-lisp-indices :doc
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
command-line-1(("-L" ";." "-l" "ert" "-l" "lisp/eshell/esh-var-tests
command-line()
normal-top-level()
Test esh-var-test/interp-lisp-indices condition:
(void-function listify)
FAILED 20/60 esh-var-test/interp-lisp-indices (0.015625 sec) at lisp/eshell/esh-var-tests.el:140
[...]
Test esh-var-test/quoted-interp-lisp-indices backtrace:
(listify 1 2)
eval((listify 1 2))
eshell-exec-lisp(eshell-print eshell-error (listify 1 2) nil t)
eshell-lisp-command((listify 1 2))
eval((eshell-lisp-command '(listify 1 2)))
eshell-do-eval((eshell-lisp-command '(listify 1 2)) t)
eshell-do-eval((progn (eshell-lisp-command '(listify 1 2)) (symbol-v
#f(compiled-function () #<bytecode -0x12ccc80303566d4e>)()
funcall(#f(compiled-function () #<bytecode -0x12ccc80303566d4e>))
(let ((eshell-current-handles '[nil (eshell-temp . 1) (eshell-temp .
eval((let ((eshell-current-handles '[nil (eshell-temp . 1) (eshell-t
eshell-do-eval((let ((eshell-current-handles '[nil (eshell-temp . 1)
#f(compiled-function () #<bytecode -0x12ccc80303566d4e>)()
funcall(#f(compiled-function () #<bytecode -0x12ccc80303566d4e>))
(let ((value 'eshell-temp) (eshell-in-pipeline-p 'nil)) (funcall '#f
eval((let ((value 'eshell-temp) (eshell-in-pipeline-p 'nil)) (funcal
eshell-do-eval((let ((value 'eshell-temp) (eshell-in-pipeline-p 'nil
eshell-do-eval((eshell-apply-indices (let ((value 'eshell-temp) (esh
#f(compiled-function () #<bytecode -0x12ccc80303566d4e>)()
funcall(#f(compiled-function () #<bytecode -0x12ccc80303566d4e>))
(let ((indices '((#("1" 0 1 (number t)))))) (funcall '#f(compiled-fu
eval((let ((indices '((#("1" 0 1 ...))))) (funcall '#f(compiled-func
eshell-do-eval((let ((indices '((#("1" 0 1 ...))))) (eshell-apply-in
eshell-do-eval((eshell-stringify (let ((indices '((...)))) (eshell-a
eshell-do-eval((eshell-escape-arg (eshell-stringify (let ((indices '
eshell-do-eval((eshell-escape-arg (eshell-escape-arg (eshell-stringi
eshell-do-eval((list (eshell-escape-arg (eshell-escape-arg (eshell-s
eshell-do-eval((eshell-named-command '"concat" (list (eshell-escape-
eshell-do-eval((prog1 (eshell-named-command '"concat" (list (eshell-
(condition-case err (eshell-do-eval '(prog1 (eshell-named-command '"
eval((condition-case err (eshell-do-eval '(prog1 (eshell-named-comma
eshell-do-eval((condition-case err (eshell-do-eval '(prog1 (eshell-n
#f(compiled-function () #<bytecode -0x12ccc80303566d4e>)()
funcall(#f(compiled-function () #<bytecode -0x12ccc80303566d4e>))
(let ((eshell-this-command-hook '(ignore))) (funcall '#f(compiled-fu
eval((let ((eshell-this-command-hook '(ignore))) (funcall '#f(compil
eshell-do-eval((let ((eshell-this-command-hook '(ignore))) (conditio
eshell-do-eval((progn (let ((eshell-this-command-hook '(ignore))) (c
#f(compiled-function () #<bytecode -0x12ccc80303566d4e>)()
funcall(#f(compiled-function () #<bytecode -0x12ccc80303566d4e>))
(let ((eshell-current-handles '[nil (eshell-temp . 1) (eshell-temp .
eval((let ((eshell-current-handles '[nil (eshell-temp . 1) (eshell-t
eshell-do-eval((let ((eshell-current-handles '[nil (eshell-temp . 1)
#f(compiled-function () #<bytecode -0x12ccc80303566d4e>)()
funcall(#f(compiled-function () #<bytecode -0x12ccc80303566d4e>))
(let ((value 'eshell-temp) (eshell-in-pipeline-p 'nil)) (funcall '#f
eval((let ((value 'eshell-temp) (eshell-in-pipeline-p 'nil)) (funcal
eshell-do-eval((let ((value 'eshell-temp) (eshell-in-pipeline-p 'nil
#f(compiled-function () #<bytecode -0x12ccc80303566d4e>)()
funcall(#f(compiled-function () #<bytecode -0x12ccc80303566d4e>))
(let ((eshell-current-handles '[nil (t . 1) (t . 1)]) (eshell-curren
eval((let ((eshell-current-handles '[nil (t . 1) (t . 1)]) (eshell-c
eshell-do-eval((let ((eshell-current-handles '[nil (t . 1) (t . 1)])
eshell-command-result("concat \"$(listify 1 2)[1]\" cool")
(let ((eshell-history-file-name nil)) (eshell-command-result command
(progn (let ((eshell-history-file-name nil)) (eshell-command-result
(unwind-protect (progn (let ((eshell-history-file-name nil)) (eshell
(let* ((coding-system-for-write nil) (temp-file (file-name-as-direct
eshell-test-command-result("concat \"$(listify 1 2)[1]\" cool")
(list (eshell-test-command-result "concat \"$(listify 1 2)[1]\" cool
(let ((signal-hook-function #'ert--should-signal-hook)) (list (eshel
(condition-case err (let ((signal-hook-function #'ert--should-signal
(let* ((fn-330 #'equal) (args-331 (condition-case err (let ((signal-
(closure (t) nil (let* ((fn-330 #'equal) (args-331 (condition-case e
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name esh-var-test/quoted-interp-lisp-indic
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
command-line-1(("-L" ";." "-l" "ert" "-l" "lisp/eshell/esh-var-tests
command-line()
normal-top-level()
Test esh-var-test/quoted-interp-lisp-indices condition:
(void-function listify)
FAILED 49/60 esh-var-test/quoted-interp-lisp-indices (0.015625 sec) at lisp/eshell/esh-var-tests.el:318
next prev parent reply other threads:[~2022-06-09 16:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-29 3:43 bug#55696: 28.1; eshell fails to respect text-scale-increase Jeff Kowalski
2022-06-03 4:41 ` Jim Porter
2022-06-03 6:31 ` Eli Zaretskii
2022-06-03 20:30 ` Jim Porter
2022-06-04 6:20 ` Eli Zaretskii
2022-06-05 4:49 ` Jim Porter
2022-06-05 9:13 ` Eli Zaretskii
2022-06-05 18:12 ` Jim Porter
2022-06-05 19:00 ` Eli Zaretskii
2022-06-05 19:59 ` Jim Porter
2022-06-06 12:43 ` Eli Zaretskii
2022-06-07 3:04 ` Jim Porter
2022-06-07 10:55 ` Eli Zaretskii
2022-06-08 8:07 ` martin rudalics
2022-06-08 23:20 ` Jim Porter
2022-06-09 7:24 ` Eli Zaretskii
2022-06-09 15:55 ` Jim Porter
2022-06-09 16:48 ` Eli Zaretskii [this message]
2022-06-09 22:14 ` Jim Porter
2022-06-10 5:52 ` Eli Zaretskii
2022-06-10 15:44 ` Jim Porter
2022-06-10 15:58 ` Eli Zaretskii
2022-06-10 16:44 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837d5p3hr7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=55696@debbugs.gnu.org \
--cc=jeff.kowalski@gmail.com \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).