From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#55696: 28.1; eshell fails to respect text-scale-increase Date: Sun, 05 Jun 2022 22:00:24 +0300 Message-ID: <83sfoj7x6f.fsf@gnu.org> References: <37af046b-4257-6370-c765-9290eae73fd4@gmail.com> <831qw6dzra.fsf@gnu.org> <0278e759-237b-a32b-4b1f-fbdacf39c8ef@gmail.com> <83pmjpar0x.fsf@gnu.org> <9e8a8b42-2f42-3027-2ec0-97744bb91911@gmail.com> <83sfoja2xp.fsf@gnu.org> <34062848-8fe4-351c-df63-5cc341fefa57@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16275"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rudalics@gmx.at, 55696@debbugs.gnu.org, jeff.kowalski@gmail.com To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 05 21:02:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nxvVq-0003zp-3Z for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Jun 2022 21:02:10 +0200 Original-Received: from localhost ([::1]:39696 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nxvVo-0001YF-Gq for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Jun 2022 15:02:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nxvUk-0001DW-Rm for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2022 15:01:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39571) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nxvUk-0005ie-IM for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2022 15:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nxvUk-0002cp-HH for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2022 15:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Jun 2022 19:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55696 X-GNU-PR-Package: emacs Original-Received: via spool by 55696-submit@debbugs.gnu.org id=B55696.16544556458907 (code B ref 55696); Sun, 05 Jun 2022 19:01:02 +0000 Original-Received: (at 55696) by debbugs.gnu.org; 5 Jun 2022 19:00:45 +0000 Original-Received: from localhost ([127.0.0.1]:33463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxvUS-0002JF-EY for submit@debbugs.gnu.org; Sun, 05 Jun 2022 15:00:44 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51986) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxvUR-0002C6-FO for 55696@debbugs.gnu.org; Sun, 05 Jun 2022 15:00:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48800) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nxvUM-0005c4-57; Sun, 05 Jun 2022 15:00:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=RTqNe61EtwNRwm43dsK1W9f2jJb5xHS1m6tXI/uuLA8=; b=U9xAY+QZfXw3 adomfY75NGsOwvVfeGzOkbjblzGVBiJ2PzQ1c+yYq6MpeE5XG10IWpOywljpINhuKD1yD4S0W5lrV gr5lRAuV9T2vKo0wt+NkVsIvFu5dRTYwCgxmQ99d+z9xNK0yti0xnLBRK/puFbileCZeOUm8pCEZa C+iftbCqpZbdBJ4jgkquYvcW1sXKg+FJXvTihWcG7WcFVrYo0Ksyo/T4OyPxZdApYYvQCRAez66iJ j8m0kf79Bzur1md7pVAry8Mry8MDn4U/KrGq7en6qRrTBbD2FDTP+gDIkoUb2rWW5LbZ/FhEFjalW KJedOGT5bVj1mN2tyUkvlQ==; Original-Received: from [87.69.77.57] (port=2926 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nxvUL-000712-97; Sun, 05 Jun 2022 15:00:37 -0400 In-Reply-To: <34062848-8fe4-351c-df63-5cc341fefa57@gmail.com> (message from Jim Porter on Sun, 5 Jun 2022 11:12:50 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:233740 Archived-At: > Cc: 55696@debbugs.gnu.org, jeff.kowalski@gmail.com > From: Jim Porter > Date: Sun, 5 Jun 2022 11:12:50 -0700 > > > I think we should optimize the frequent case where > > Vface_remapping_alist is nil, in which case BODY_IN_REMAPPED_CHARS is > > the same as BODY_IN_CANONICAL_CHARS. lookup_named_face is not a > > trivial function, so it is best to avoid calling it whenever possible. > > Good point. How does the updated implementation look? Looks okay, except for one thing: > + if (pixelwise == BODY_IN_REMAPPED_CHARS) > + { > + if (Vface_remapping_alist) This should be if (!NILP (Vface_remapping_alist)) because the implementation of nil is not necessarily an integer zero. You will get compilation errors if you configure with the "--enable-check-lisp-object-type" option. I will do a more thorough review tomorrow.