unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 31376@debbugs.gnu.org, schwab@linux-m68k.org, eller.helmut@gmail.com
Subject: bug#31376: 26.0.50; print-charset-text-property not honored
Date: Sun, 13 May 2018 18:29:34 +0300	[thread overview]
Message-ID: <83r2mflgkh.fsf@gnu.org> (raw)
In-Reply-To: <871seglk1y.fsf@gmail.com> (message from Noam Postavsky on Sat, 12 May 2018 16:02:01 -0400)

> From: Noam Postavsky <npostavs@gmail.com>
> Cc: handa@gnu.org,  schwab@linux-m68k.org,  31376@debbugs.gnu.org,  eller.helmut@gmail.com
> Date: Sat, 12 May 2018 16:02:01 -0400
> 
> Okay, how about this:
> 
> >From eed29c8e7164cbc13df4d7b4e3974ae90d9ecb51 Mon Sep 17 00:00:00 2001
> From: Noam Postavsky <npostavs@gmail.com>
> Date: Fri, 11 May 2018 13:44:46 -0400
> Subject: [PATCH] Honor print-charset-text-property value of nil (Bug#31376)
> 
> * src/print.c (print_check_string_charset_prop): Move check
> for nil Vprint_charset_text_property from here...
> (print_prune_string_charset): ... to here.
> (syms_of_print) <print-charset-text-property>: Clarify that any
> non-boolean values are treated the same as `default'.
> * doc/lispref/streams.texi (Output Variables): Add
> print-prune-string-charset.

Could we also have a couple of tests, including the original snippet
from Helmut that started this?

> +@defvar print-charset-text-property
> +This variable controls printing of `charset' text property on printing
> +a string.  The value should be @code{nil}, @code{t}, or
> +@code{default}.
> +
> +If the value is @code{nil}, @code{charset} text properties are never
> +printed.  If @code{t}, they are always printed.  If the value is
> +@code{default}, print the text property @code{charset} only when the
> +value is different from what is guessed in the current charset
> +priorities.  Values other than @code{nil} or @code{t} are treated the
> +same as @code{default}.
> +@end defvar

This LGTM, but the description of 'default' IMO is too
implementation-centric, which doesn't help the user in understanding
what to expect from that value.  How about the variant below?

  If the value is @code{default}, print only those @code{charset} text
  properties that are ``unusual'' for the respective characters under
  the current language environment.  The @code{charset} property of a
  character is considered unusual if its value is different from what
  @code{char-charset} returns for that character.

Thanks.





  reply	other threads:[~2018-05-13 15:29 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-07  6:48 bug#31376: 26.0.50; print-charset-text-property not honored Helmut Eller
2018-05-07  7:58 ` Andreas Schwab
2018-05-07  8:38   ` Helmut Eller
2018-05-07 12:57     ` Noam Postavsky
2018-05-07 18:08       ` Helmut Eller
2018-05-11 13:31         ` Eli Zaretskii
2018-05-11 17:44           ` Noam Postavsky
2018-05-11 18:45             ` Eli Zaretskii
2018-05-12 20:02               ` Noam Postavsky
2018-05-13 15:29                 ` Eli Zaretskii [this message]
2018-05-13 18:29                   ` Noam Postavsky
2018-05-13 18:51                     ` Eli Zaretskii
2018-05-13 19:42                       ` Noam Postavsky
2018-05-14 16:34                         ` Eli Zaretskii
2018-05-14 23:15                           ` Noam Postavsky
2018-05-15 17:19                             ` Eli Zaretskii
2018-05-15 23:37                               ` Noam Postavsky
2018-05-23 23:12                                 ` Noam Postavsky
     [not found]             ` <<837eoani9b.fsf@gnu.org>
2018-05-11 19:58               ` Drew Adams
2018-05-12  6:10                 ` Eli Zaretskii
     [not found] <<m2zi1c6jvo.fsf@caladan>

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r2mflgkh.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=31376@debbugs.gnu.org \
    --cc=eller.helmut@gmail.com \
    --cc=npostavs@gmail.com \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).