From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 31376@debbugs.gnu.org, schwab@linux-m68k.org, eller.helmut@gmail.com
Subject: bug#31376: 26.0.50; print-charset-text-property not honored
Date: Fri, 11 May 2018 21:45:36 +0300 [thread overview]
Message-ID: <837eoani9b.fsf@gnu.org> (raw)
In-Reply-To: <CAM-tV--UFsEpeU2yuwNJ7XM6d5QBNJLRKqgBooAzxrqPhW30og@mail.gmail.com> (message from Noam Postavsky on Fri, 11 May 2018 13:44:46 -0400)
> From: Noam Postavsky <npostavs@gmail.com>
> Date: Fri, 11 May 2018 13:44:46 -0400
> Cc: Helmut Eller <eller.helmut@gmail.com>, Kenichi Handa <handa@gnu.org>, 31376@debbugs.gnu.org,
> Andreas Schwab <schwab@linux-m68k.org>
>
> On 11 May 2018 at 09:31, Eli Zaretskii <eliz@gnu.org> wrote:
>
> > Can someone see any difference between the value t and 'default', wrt
> ^
> nil
> > when/how the 'charset' property of strings is printed?
>
> Assuming you meant nil, then no, I can't see any difference.
Mmm... yes, nil.
> As far as
> I can tell, setting to 'default' just makes Emacs do pointless extra
> checking for "unsafe" charsets even after it has found one.
You mean, setting it to nil makes it do pointless extra work, yes? ;-)
> It looks like the NILP (Vprint_charset_text_property) check is just in
> the wrong place, if I move it to print_prune_string_charset then it
> seems to work as documented.
>
> --- i/src/print.c
> +++ w/src/print.c
> @@ -1317,8 +1317,7 @@ print_check_string_charset_prop (INTERVAL interval,
> || CONSP (XCDR (XCDR (val))))
> print_check_string_result |= PRINT_STRING_NON_CHARSET_FOUND;
> }
> - if (NILP (Vprint_charset_text_property)
> - || ! (print_check_string_result & PRINT_STRING_UNSAFE_CHARSET_FOUND))
> + if (! (print_check_string_result & PRINT_STRING_UNSAFE_CHARSET_FOUND))
> {
> int i, c;
> ptrdiff_t charpos = interval->position;
> @@ -1348,7 +1347,8 @@ print_prune_string_charset (Lisp_Object string)
> print_check_string_result = 0;
> traverse_intervals (string_intervals (string), 0,
> print_check_string_charset_prop, string);
> - if (! (print_check_string_result & PRINT_STRING_UNSAFE_CHARSET_FOUND))
> + if (NILP (Vprint_charset_text_property)
> + || ! (print_check_string_result & PRINT_STRING_UNSAFE_CHARSET_FOUND))
Yes, that sounds right, thanks. We should also mention in the doc
string that any non-nil, non-t value is treated as 'default'.
And this variable should be mentioned in the ELisp manual, in the node
"Output Variables".
next prev parent reply other threads:[~2018-05-11 18:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 6:48 bug#31376: 26.0.50; print-charset-text-property not honored Helmut Eller
2018-05-07 7:58 ` Andreas Schwab
2018-05-07 8:38 ` Helmut Eller
2018-05-07 12:57 ` Noam Postavsky
2018-05-07 18:08 ` Helmut Eller
2018-05-11 13:31 ` Eli Zaretskii
2018-05-11 17:44 ` Noam Postavsky
2018-05-11 18:45 ` Eli Zaretskii [this message]
2018-05-12 20:02 ` Noam Postavsky
2018-05-13 15:29 ` Eli Zaretskii
2018-05-13 18:29 ` Noam Postavsky
2018-05-13 18:51 ` Eli Zaretskii
2018-05-13 19:42 ` Noam Postavsky
2018-05-14 16:34 ` Eli Zaretskii
2018-05-14 23:15 ` Noam Postavsky
2018-05-15 17:19 ` Eli Zaretskii
2018-05-15 23:37 ` Noam Postavsky
2018-05-23 23:12 ` Noam Postavsky
[not found] ` <<837eoani9b.fsf@gnu.org>
2018-05-11 19:58 ` Drew Adams
2018-05-12 6:10 ` Eli Zaretskii
[not found] <<m2zi1c6jvo.fsf@caladan>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837eoani9b.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=31376@debbugs.gnu.org \
--cc=eller.helmut@gmail.com \
--cc=npostavs@gmail.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).