From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31376: 26.0.50; print-charset-text-property not honored Date: Sun, 13 May 2018 18:29:34 +0300 Message-ID: <83r2mflgkh.fsf@gnu.org> References: <87d0y7ew2h.fsf@linux-m68k.org> <87603zmxna.fsf@gmail.com> <83mux6nws8.fsf@gnu.org> <837eoani9b.fsf@gnu.org> <871seglk1y.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1526225291 12070 195.159.176.226 (13 May 2018 15:28:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 13 May 2018 15:28:11 +0000 (UTC) Cc: 31376@debbugs.gnu.org, schwab@linux-m68k.org, eller.helmut@gmail.com To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 13 17:28:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHsur-0002zm-Ag for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 May 2018 17:28:05 +0200 Original-Received: from localhost ([::1]:47005 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHswy-0005Jv-89 for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 May 2018 11:30:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHswn-0005I3-CA for bug-gnu-emacs@gnu.org; Sun, 13 May 2018 11:30:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fHswk-0007Jr-8L for bug-gnu-emacs@gnu.org; Sun, 13 May 2018 11:30:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53055) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fHswk-0007Je-4X for bug-gnu-emacs@gnu.org; Sun, 13 May 2018 11:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fHswj-0005HI-Qt for bug-gnu-emacs@gnu.org; Sun, 13 May 2018 11:30:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 May 2018 15:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31376 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 31376-submit@debbugs.gnu.org id=B31376.152622538520241 (code B ref 31376); Sun, 13 May 2018 15:30:01 +0000 Original-Received: (at 31376) by debbugs.gnu.org; 13 May 2018 15:29:45 +0000 Original-Received: from localhost ([127.0.0.1]:60952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHswT-0005GO-2E for submit@debbugs.gnu.org; Sun, 13 May 2018 11:29:45 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHswS-0005GC-03 for 31376@debbugs.gnu.org; Sun, 13 May 2018 11:29:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fHswM-000745-0V for 31376@debbugs.gnu.org; Sun, 13 May 2018 11:29:38 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46619) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHswG-000717-SW; Sun, 13 May 2018 11:29:32 -0400 Original-Received: from [176.228.60.248] (port=3092 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fHswG-00017N-Bl; Sun, 13 May 2018 11:29:32 -0400 In-reply-to: <871seglk1y.fsf@gmail.com> (message from Noam Postavsky on Sat, 12 May 2018 16:02:01 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146151 Archived-At: > From: Noam Postavsky > Cc: handa@gnu.org, schwab@linux-m68k.org, 31376@debbugs.gnu.org, eller.helmut@gmail.com > Date: Sat, 12 May 2018 16:02:01 -0400 > > Okay, how about this: > > >From eed29c8e7164cbc13df4d7b4e3974ae90d9ecb51 Mon Sep 17 00:00:00 2001 > From: Noam Postavsky > Date: Fri, 11 May 2018 13:44:46 -0400 > Subject: [PATCH] Honor print-charset-text-property value of nil (Bug#31376) > > * src/print.c (print_check_string_charset_prop): Move check > for nil Vprint_charset_text_property from here... > (print_prune_string_charset): ... to here. > (syms_of_print) : Clarify that any > non-boolean values are treated the same as `default'. > * doc/lispref/streams.texi (Output Variables): Add > print-prune-string-charset. Could we also have a couple of tests, including the original snippet from Helmut that started this? > +@defvar print-charset-text-property > +This variable controls printing of `charset' text property on printing > +a string. The value should be @code{nil}, @code{t}, or > +@code{default}. > + > +If the value is @code{nil}, @code{charset} text properties are never > +printed. If @code{t}, they are always printed. If the value is > +@code{default}, print the text property @code{charset} only when the > +value is different from what is guessed in the current charset > +priorities. Values other than @code{nil} or @code{t} are treated the > +same as @code{default}. > +@end defvar This LGTM, but the description of 'default' IMO is too implementation-centric, which doesn't help the user in understanding what to expect from that value. How about the variant below? If the value is @code{default}, print only those @code{charset} text properties that are ``unusual'' for the respective characters under the current language environment. The @code{charset} property of a character is considered unusual if its value is different from what @code{char-charset} returns for that character. Thanks.