From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51891: 29.0.50; [PATCH] Pixel delta support for wheel events on X Date: Wed, 17 Nov 2021 15:33:29 +0200 Message-ID: <83r1bezz2u.fsf@gnu.org> References: <87zgq4uvh0.fsf.ref@yahoo.com> <87zgq4uvh0.fsf@yahoo.com> <871r3gnrrn.fsf@gmail.com> <875ysrtyak.fsf@yahoo.com> <871r3ftsjy.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40571"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rpluim@gmail.com, 51891@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 17 14:42:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mnLCe-000AKX-P1 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Nov 2021 14:42:20 +0100 Original-Received: from localhost ([::1]:56670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mnLCd-0001gE-Dk for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Nov 2021 08:42:19 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnL4c-0003M8-CK for bug-gnu-emacs@gnu.org; Wed, 17 Nov 2021 08:34:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48899) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mnL4c-0005Fl-2R for bug-gnu-emacs@gnu.org; Wed, 17 Nov 2021 08:34:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mnL4b-0000ul-UH for bug-gnu-emacs@gnu.org; Wed, 17 Nov 2021 08:34:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Nov 2021 13:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51891 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51891-submit@debbugs.gnu.org id=B51891.16371560243480 (code B ref 51891); Wed, 17 Nov 2021 13:34:01 +0000 Original-Received: (at 51891) by debbugs.gnu.org; 17 Nov 2021 13:33:44 +0000 Original-Received: from localhost ([127.0.0.1]:60445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnL4J-0000u3-NM for submit@debbugs.gnu.org; Wed, 17 Nov 2021 08:33:43 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnL4H-0000tf-Al for 51891@debbugs.gnu.org; Wed, 17 Nov 2021 08:33:42 -0500 Original-Received: from [2001:470:142:3::e] (port=59342 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnL4C-0005CP-29; Wed, 17 Nov 2021 08:33:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=MTydqDV1UP8tYr8BXbHC1OBXaTkzjaR3Uvkdj26haoo=; b=TIP3oUhxVrZo HeluXGI5o63auIxIepwhVjhOdFlypa+6aV1T6M3Gi5tp3QSP3/HaeoMw2of0bndhWTOaVgm8LpTjK 3Kb50ScJjUKVwCxM1V7ESw+jYvk8W8SSh+uvM1tNLq93LHUIm5hv9itYDsCZPDWk7/mgmpbZ1M8Lx xtFFRWDqiizsmQ/8PC1KjHskHiY9y6DBj5O/GiNGyadwNEIvTJOCo4cLXlFoByVGEKvWGkO9RvIkO tu2hHjVpbbuMi8uhzmWspKI0M/VJHBJtGivYgZHw3GPOqsEco9QVAV6hNGJVTcRo/5liR+szO+p9L 8ZMDF+lwmZ8sqjDg4KOk2Q==; Original-Received: from [87.69.77.57] (port=2304 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnL4A-000845-Ml; Wed, 17 Nov 2021 08:33:36 -0500 In-Reply-To: <871r3ftsjy.fsf@yahoo.com> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220200 Archived-At: > Cc: 51891@debbugs.gnu.org > Date: Wed, 17 Nov 2021 10:38:41 +0800 > From: Po Lu via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > --- a/doc/lispref/commands.texi > +++ b/doc/lispref/commands.texi > @@ -1985,7 +1985,11 @@ Misc Events > These kinds of event are generated by moving a mouse wheel. The > @var{position} element is a mouse position list (@pxref{Click > Events}), specifying the position of the mouse cursor when the event > -occurred. > +occurred. The event may have additional arguments after > +@var{position}. The third argument after @var{position}, if present, > +is a property list of the form @w{@code{(:delta-x @var{x} :delta-y > +@var{y})}}, where @var{x} and @var{y} are the number of pixels to > +scroll by in each axis. Did you consider the possibility of defining a new event? And should mwheel.el be aware of this change somehow? And finally, why introduce keyword-value pairs into a form that didn't use them before? Can we store just the values there? > + scroll_unit = pow (FRAME_PIXEL_HEIGHT (f), 2.0 / 3.0); Ouch! can we avoid calling 'pow' here? It's an expensive function. > + DEFVAR_BOOL ("x-coalesce-scroll-events", x_coalesce_scroll_events, > + doc: /* Non-nil means to only send one wheel event for each scroll unit. > +Otherwise, a wheel event will be sent every time the mouse wheel is > +moved. This is confusing: what does "scroll unit" mean in this context?