From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23540: 25.1.50; make-ipv4-tcp-server-with-unspecified-port fails Date: Tue, 24 May 2016 18:27:29 +0300 Message-ID: <83posb4gta.fsf@gnu.org> References: <83futj5mcl.fsf@gnu.org> <1181b6a8-c007-fbec-cb25-991a716c7b14@cornell.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1464104189 19526 80.91.229.3 (24 May 2016 15:36:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 24 May 2016 15:36:29 +0000 (UTC) Cc: 23540@debbugs.gnu.org, larsi@gnus.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 24 17:36:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b5ENR-0005sC-Kx for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 May 2016 17:36:13 +0200 Original-Received: from localhost ([::1]:53997 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5ENQ-00028S-TT for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 May 2016 11:36:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40873) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5EFc-0003Or-Ev for bug-gnu-emacs@gnu.org; Tue, 24 May 2016 11:28:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5EFW-0005O4-QW for bug-gnu-emacs@gnu.org; Tue, 24 May 2016 11:28:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52435) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5EFW-0005Ny-Mx for bug-gnu-emacs@gnu.org; Tue, 24 May 2016 11:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b5EFW-0005Mv-DQ for bug-gnu-emacs@gnu.org; Tue, 24 May 2016 11:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 May 2016 15:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23540 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23540-submit@debbugs.gnu.org id=B23540.146410367320622 (code B ref 23540); Tue, 24 May 2016 15:28:02 +0000 Original-Received: (at 23540) by debbugs.gnu.org; 24 May 2016 15:27:53 +0000 Original-Received: from localhost ([127.0.0.1]:36539 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b5EFM-0005MX-SF for submit@debbugs.gnu.org; Tue, 24 May 2016 11:27:53 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:49733) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b5EFL-0005ML-Tk for 23540@debbugs.gnu.org; Tue, 24 May 2016 11:27:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5EFC-0005Gf-UU for 23540@debbugs.gnu.org; Tue, 24 May 2016 11:27:46 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60522) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5EF2-0005ET-2D; Tue, 24 May 2016 11:27:32 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4360 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b5EF0-0000hZ-Nc; Tue, 24 May 2016 11:27:31 -0400 In-reply-to: <1181b6a8-c007-fbec-cb25-991a716c7b14@cornell.edu> (message from Ken Brown on Tue, 24 May 2016 11:09:00 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118620 Archived-At: > Cc: 23540@debbugs.gnu.org, larsi@gnus.org > From: Ken Brown > Date: Tue, 24 May 2016 11:09:00 -0400 > > On 5/15/2016 1:08 PM, Ken Brown wrote: > > On 5/15/2016 12:15 PM, Eli Zaretskii wrote: > >> Ffind_operation_coding_system includes an explicit test for the 4th > >> argument to be an integer: > >> > >> if (!(STRINGP (target) > >> || (EQ (operation, Qinsert_file_contents) && CONSP (target) > >> && STRINGP (XCAR (target)) && BUFFERP (XCDR (target))) > >> || (EQ (operation, Qopen_network_stream) && INTEGERP (target)))) > >> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > >> error ("Invalid argument %"pI"d of operation `%s'", > >> XFASTINT (target_idx) + 1, SDATA (SYMBOL_NAME (operation))); > >> > >> This should obviously be augmented, now that the value can also be t. > > > > Presumably the documentation of open-network-stream should also be > > updated to reflect this. I hesitate to do this myself without knowing > > for sure that t is an acceptable value for all calls to > > open-network-stream. I'd rather leave it for someone more familiar with > > the code, like Lars. > > I went ahead and installed the obvious fix, to get rid of the test > failure. Thanks.