From: Eli Zaretskii <eliz@gnu.org>
To: jostein@kjonigsen.net
Cc: casouri@gmail.com, 61104@debbugs.gnu.org, theo@thornhill.no
Subject: bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support
Date: Fri, 27 Jan 2023 22:30:02 +0200 [thread overview]
Message-ID: <83o7qjbu0l.fsf@gnu.org> (raw)
In-Reply-To: <316aee65-50c6-9dad-5b8d-08d90675c5a5@secure.kjonigsen.net> (message from Jostein Kjønigsen on Fri, 27 Jan 2023 21:14:30 +0100)
> Cc: Yuan Fu <casouri@gmail.com>, Theodor Thornhill <theo@thornhill.no>
> Date: Fri, 27 Jan 2023 21:14:30 +0100
> From: Jostein Kjønigsen <jostein@secure.kjonigsen.net>
>
> When compiling a TypeScript project using tsc (or other tooling) from Emacs,
> compilation errors and warnings are not highlighted by compilation-mode.
>
> Consider the following output:
>
> src/resources/document.ts:140:22 - error TS2362: The left-hand side of an arithmetic operation must be of
> type 'any', 'number', 'bigint' or an enum type.
>
> 140 return `File-${new Date() * 1}${ext}`;
> ~~~~~~~~~~
>
> This output should cause compilation-mode to highlight the error and provide code-navigation.
>
> I know we explicitly added support for this to typescript.el back in the days, but I'm not
> sure what the "right" thing to do is now that typescrip-ts-mode is a first class Emacs citizen.
>
> Should we add compilation-mode patterns directly to the major-mode, or should we provide
> patches to compile.el instead?
Why isn't this part of compilation-error-regexp-alist-alist?
next prev parent reply other threads:[~2023-01-27 20:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 20:14 bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support Jostein Kjønigsen
2023-01-27 20:30 ` Eli Zaretskii [this message]
2023-01-27 20:52 ` Jostein Kjønigsen
2023-01-28 7:23 ` Eli Zaretskii
2023-01-28 14:28 ` Jostein Kjønigsen
2023-02-02 21:01 ` Jostein Kjønigsen
2023-02-03 5:30 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-03 7:06 ` Eli Zaretskii
2023-02-03 8:00 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-04 8:24 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-04 11:59 ` Mattias Engdegård
2023-02-05 20:36 ` Jostein Kjønigsen
2023-02-06 11:19 ` Mattias Engdegård
2023-02-06 17:05 ` Jostein Kjønigsen
2023-02-06 17:34 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83o7qjbu0l.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=61104@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=jostein@kjonigsen.net \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).