From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: jostein@kjonigsen.net, casouri@gmail.com, 61104@debbugs.gnu.org,
jostein@secure.kjonigsen.net
Subject: bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support
Date: Sat, 04 Feb 2023 09:24:49 +0100 [thread overview]
Message-ID: <87sfflhm7i.fsf@thornhill.no> (raw)
In-Reply-To: <87h6w3ch5b.fsf@thornhill.no> (Theodor Thornhill's message of "Fri, 03 Feb 2023 09:00:48 +0100")
Theodor Thornhill <theo@thornhill.no> writes:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> Date: Fri, 03 Feb 2023 06:30:29 +0100
>>> From: Theodor Thornhill <theo@thornhill.no>
>>> CC: 61104@debbugs.gnu.org, casouri@gmail.com
>>>
>>> On 2 February 2023 22:01:11 CET, "Jostein Kjønigsen" <jostein@secure.kjonigsen.net> wrote:
>>> >Any news on this one? Will this be merged? :)
>>> >
>>>
>>> My guess is that it should go on master. I'll look at it today - sorry it took some time :)
>>
>> I'm okay with installing this on emacs-29 if the patch looks good.
>> Typescript mode is new in Emacs 29, so it's okay to make this change
>> now. But please be sure that the relevant tests still pass, i.e. that
>> this change doesn't break something else in compilation-mode.
>>
>> Thanks.
>
> Ok, I'll do that then. I'll add this in addition in the next commit, if
> that's ok.
>
> Thanks, Jostein and Eli :)
The changes are now installed on the emacs-29 branch, thanks!
Closing this :)
Theo
next prev parent reply other threads:[~2023-02-04 8:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 20:14 bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support Jostein Kjønigsen
2023-01-27 20:30 ` Eli Zaretskii
2023-01-27 20:52 ` Jostein Kjønigsen
2023-01-28 7:23 ` Eli Zaretskii
2023-01-28 14:28 ` Jostein Kjønigsen
2023-02-02 21:01 ` Jostein Kjønigsen
2023-02-03 5:30 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-03 7:06 ` Eli Zaretskii
2023-02-03 8:00 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-04 8:24 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-02-04 11:59 ` Mattias Engdegård
2023-02-05 20:36 ` Jostein Kjønigsen
2023-02-06 11:19 ` Mattias Engdegård
2023-02-06 17:05 ` Jostein Kjønigsen
2023-02-06 17:34 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfflhm7i.fsf@thornhill.no \
--to=bug-gnu-emacs@gnu.org \
--cc=61104@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=jostein@kjonigsen.net \
--cc=jostein@secure.kjonigsen.net \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).