From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support Date: Fri, 27 Jan 2023 22:30:02 +0200 Message-ID: <83o7qjbu0l.fsf@gnu.org> References: <316aee65-50c6-9dad-5b8d-08d90675c5a5@secure.kjonigsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17109"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, 61104@debbugs.gnu.org, theo@thornhill.no To: jostein@kjonigsen.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 27 21:31:51 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLVO1-0004Ee-W0 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Jan 2023 21:31:50 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pLVNM-00057n-FU; Fri, 27 Jan 2023 15:31:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLVNH-00055E-8p for bug-gnu-emacs@gnu.org; Fri, 27 Jan 2023 15:31:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pLVNG-0003Du-MR for bug-gnu-emacs@gnu.org; Fri, 27 Jan 2023 15:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pLVNG-0006GY-7s for bug-gnu-emacs@gnu.org; Fri, 27 Jan 2023 15:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Jan 2023 20:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61104 X-GNU-PR-Package: emacs Original-Received: via spool by 61104-submit@debbugs.gnu.org id=B61104.167485142924044 (code B ref 61104); Fri, 27 Jan 2023 20:31:02 +0000 Original-Received: (at 61104) by debbugs.gnu.org; 27 Jan 2023 20:30:29 +0000 Original-Received: from localhost ([127.0.0.1]:38570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLVMj-0006Fk-8r for submit@debbugs.gnu.org; Fri, 27 Jan 2023 15:30:29 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLVMh-0006FX-0D for 61104@debbugs.gnu.org; Fri, 27 Jan 2023 15:30:28 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLVMb-00035D-47; Fri, 27 Jan 2023 15:30:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=bmE4ksOsePkfdgVVvLi3BlX7tmBEXw7SSLppZ/qXaoo=; b=X/PZdC1VXK56Ud7uEieI Ru+ZMJ8g6ZtXVmIuRMh9EDO0sXnMq9wUdZEyUdTxvQLJ2zTLYikTji0HUPcuV6KpFsKFQNDiJylj2 LhbTYg+LlsCQI7Yy7PUjSTor1hSC1V+e2oxLRom8LLdECAaa5YVN+SjU8k8mWTSg3bHAnEkzReiFk 8HRLHCds3KYuQar+8kGxUiPuJsjC9K3tQd7ooZ3Ui+VrGjz9nnlCj4XdOzi2tRnCpfBuQZuWCz74r 5O77L14EQPfA+lincDaLjISWTonOr/pn/s4UJHBr7R9v8S8k+BxOAYOg4DQMWAyQNhYdvbhtiYgjo kTsOrQXesegxzg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLVMX-0002M8-2i; Fri, 27 Jan 2023 15:30:17 -0500 In-Reply-To: <316aee65-50c6-9dad-5b8d-08d90675c5a5@secure.kjonigsen.net> (message from Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= on Fri, 27 Jan 2023 21:14:30 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254274 Archived-At: > Cc: Yuan Fu , Theodor Thornhill > Date: Fri, 27 Jan 2023 21:14:30 +0100 > From: Jostein Kjønigsen > > When compiling a TypeScript project using tsc (or other tooling) from Emacs, > compilation errors and warnings are not highlighted by compilation-mode. > > Consider the following output: > > src/resources/document.ts:140:22 - error TS2362: The left-hand side of an arithmetic operation must be of > type 'any', 'number', 'bigint' or an enum type. > > 140 return `File-${new Date() * 1}${ext}`; > ~~~~~~~~~~ > > This output should cause compilation-mode to highlight the error and provide code-navigation. > > I know we explicitly added support for this to typescript.el back in the days, but I'm not > sure what the "right" thing to do is now that typescrip-ts-mode is a first class Emacs citizen. > > Should we add compilation-mode patterns directly to the major-mode, or should we provide > patches to compile.el instead? Why isn't this part of compilation-error-regexp-alist-alist?