From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63625: 29.0.90; package-install inserts package directory into load-path twice. Date: Mon, 22 May 2023 18:53:47 +0300 Message-ID: <83o7mcpdkk.fsf@gnu.org> References: <4ACD9E26-B5A6-412E-8DFC-C09C05A4EACD@mac.com> <871qj8lp8u.fsf@gmail.com> <87bkicjvne.fsf@gmail.com> <877ct0js46.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15767"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, toddasmith@mac.com, monnier@iro.umontreal.ca, 63625@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 22 17:54:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q17rR-0003rz-Q2 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 May 2023 17:54:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q17rI-0005wZ-2I; Mon, 22 May 2023 11:54:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q17rG-0005wI-OD for bug-gnu-emacs@gnu.org; Mon, 22 May 2023 11:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q17rG-00064v-CQ for bug-gnu-emacs@gnu.org; Mon, 22 May 2023 11:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q17rG-0005dL-8i for bug-gnu-emacs@gnu.org; Mon, 22 May 2023 11:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 May 2023 15:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63625 X-GNU-PR-Package: emacs Original-Received: via spool by 63625-submit@debbugs.gnu.org id=B63625.168477081421616 (code B ref 63625); Mon, 22 May 2023 15:54:02 +0000 Original-Received: (at 63625) by debbugs.gnu.org; 22 May 2023 15:53:34 +0000 Original-Received: from localhost ([127.0.0.1]:36018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q17qn-0005ca-EL for submit@debbugs.gnu.org; Mon, 22 May 2023 11:53:33 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q17ql-0005c6-51 for 63625@debbugs.gnu.org; Mon, 22 May 2023 11:53:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q17qf-0005vQ-78; Mon, 22 May 2023 11:53:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+X0+dDGNMznVErq/lf3EdKROYkSO91phqNoz5EgN/u0=; b=VEG/ZSpc4tI+ +53yH6LZajoeyhG7GX3yFA5ZRn3SDNjrEzLqx9Ufu3njB4txuAm1rj3s1sSUgNSpmu61wXeTVqrKY srK336qupc93yXlSRv2keizUoSjEOCsSEH3szvKSkVvY8uW34ESqfAYwsyD4RMj1hrUk3lpDCLFRY u5GuweCsxEmK8wGy/cwVe3e3QVE9upYC8mYDcFVkKmHB0yvr1kge/sBR/JcnHQVw7poZrUgZRhUZj BEfkZBxNfR6wM5gMuhLG4X78CWnD1Imtahk3Vs9BfwwIc0htlA3QuiyvdzrLysT/Ae2VCUXJEUlMI htjC6ioFHTorTKBgP3bvpA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q17qe-0003aD-M4; Mon, 22 May 2023 11:53:24 -0400 In-Reply-To: <877ct0js46.fsf@gmail.com> (message from Robert Pluim on Mon, 22 May 2023 17:36:09 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262166 Archived-At: > Cc: Philip Kaludercic , 63625@debbugs.gnu.org, > todd smith > From: Robert Pluim > Date: Mon, 22 May 2023 17:36:09 +0200 > > Stefan> (package--reload-previously-loaded pkg-desc)) > Stefan> (with-demoted-errors "Error loading autoloads: %s" > Stefan> (load (package--autoloads-file-name pkg-desc) nil t)) > Stefan> - (add-to-list 'load-path (directory-file-name pkg-dir))) > Stefan> + ;; FIXME: Since 2013 (commit 4fac34cee97a), the autoload files take > Stefan> + ;; care of changing the `load-path', so maybe it's time to > Stefan> + ;; remove this fallback code? > Stefan> + (unless (or (member (file-name-as-directory pkg-dir) load-path) > Stefan> + (member (directory-file-name pkg-dir) load-path)) > Stefan> + (add-to-list 'load-path pkg-dir))) > > Stefan> Maybe we can have that patch in emacs-29 and remove the code altogether > Stefan> on `master`? > > That seems reasonable. Eli? I'm a bit confused by "that patch" and stuff, and would prefer to see the patch for emacs-29 and another for master, please. Thanks.