From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: xfq.free@gmail.com, rgm@gnu.org, monnier@iro.umontreal.ca,
13521@debbugs.gnu.org
Subject: bug#13521: `sort-lines' on the empty region
Date: Fri, 21 Aug 2020 09:22:35 +0300 [thread overview]
Message-ID: <83mu2objro.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkm=SDc3obOA_KXvtWOBRay+aWtnOtkKX5SGPwXGVB=+hYg@mail.gmail.com> (message from Stefan Kangas on Thu, 20 Aug 2020 18:18:34 -0700)
> From: Stefan Kangas <stefan@marxist.se>
> Date: Thu, 20 Aug 2020 18:18:34 -0700
> Cc: Xue Fuqiao <xfq.free@gmail.com>, Glenn Morris <rgm@gnu.org>,
> 13521@debbugs.gnu.org
>
> > I personally prefer the "whole buffer", but whoever makes the change
> > gets to make the choice.
>
> The attached patch makes 'sort-lines' sort the entire buffer when there
> is no region.
How frequently did you see a buffer in Emacs with no region in it?
IME, it takes about 2 commands since buffer creation to have a region
in it. So I predict users to be tripped by this feature quite a lot:
they will think there's no region, invoke the command, and get some
arbitrary region sorted. Requiring them to always provide the region
avoids this pitfall, since the user is forced to make sure the region
is where he or she wants it. And marking the whole buffer is just 2
key-presses away.
So I think this change will annoy more than help.
next prev parent reply other threads:[~2020-08-21 6:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 0:53 bug#13521: `sort-lines' on the empty region Xue Fuqiao
2013-01-22 3:19 ` Glenn Morris
2013-01-22 3:44 ` Xue Fuqiao
2013-01-22 3:44 ` Xue Fuqiao
2013-01-22 14:59 ` Stefan Monnier
2013-01-22 18:19 ` Glenn Morris
2013-01-22 19:04 ` Stefan Monnier
2020-08-21 1:18 ` Stefan Kangas
2020-08-21 6:22 ` Eli Zaretskii [this message]
2020-08-21 7:15 ` Stefan Kangas
2020-08-21 7:36 ` Eli Zaretskii
2020-09-05 11:13 ` Stefan Kangas
2020-09-05 11:29 ` Eli Zaretskii
2021-05-10 11:25 ` Lars Ingebrigtsen
[not found] <<20130122085354.75ced82538551655e724e0ea@gmail.com>
[not found] ` <<jwvobgh2rkw.fsf-monnier+emacs@gnu.org>
[not found] ` <<i2ehhdaxnq.fsf@fencepost.gnu.org>
[not found] ` <<jwv1udd2gab.fsf-monnier+emacs@gnu.org>
[not found] ` <<CADwFkm=SDc3obOA_KXvtWOBRay+aWtnOtkKX5SGPwXGVB=+hYg@mail.gmail.com>
[not found] ` <<83mu2objro.fsf@gnu.org>
[not found] ` <<CADwFkmnf6ch6CBN13opEWDVnZYY-TaT236xg21Qg2KjWuUVz+w@mail.gmail.com>
[not found] ` <<83imdcbgc5.fsf@gnu.org>
[not found] ` <<CADwFkm=V7cUz2_5Xr8=k6EZbFK96pJu8wpo6uAA+H7ABDYdH0w@mail.gmail.com>
[not found] ` <<83imcspim8.fsf@gnu.org>
2020-09-05 14:36 ` Drew Adams
2020-09-05 14:51 ` Eli Zaretskii
2020-09-05 15:34 ` Stefan Monnier
[not found] <<<20130122085354.75ced82538551655e724e0ea@gmail.com>
[not found] ` <<<jwvobgh2rkw.fsf-monnier+emacs@gnu.org>
[not found] ` <<<i2ehhdaxnq.fsf@fencepost.gnu.org>
[not found] ` <<<jwv1udd2gab.fsf-monnier+emacs@gnu.org>
[not found] ` <<<CADwFkm=SDc3obOA_KXvtWOBRay+aWtnOtkKX5SGPwXGVB=+hYg@mail.gmail.com>
[not found] ` <<<83mu2objro.fsf@gnu.org>
[not found] ` <<<CADwFkmnf6ch6CBN13opEWDVnZYY-TaT236xg21Qg2KjWuUVz+w@mail.gmail.com>
[not found] ` <<<83imdcbgc5.fsf@gnu.org>
[not found] ` <<<CADwFkm=V7cUz2_5Xr8=k6EZbFK96pJu8wpo6uAA+H7ABDYdH0w@mail.gmail.com>
[not found] ` <<<83imcspim8.fsf@gnu.org>
[not found] ` <<3aad96d8-2503-40e8-b684-8ed18a089083@default>
[not found] ` <<83a6y4p98g.fsf@gnu.org>
2020-09-05 15:22 ` Drew Adams
2020-09-05 15:37 ` Eli Zaretskii
[not found] <<<<20130122085354.75ced82538551655e724e0ea@gmail.com>
[not found] ` <<<<jwvobgh2rkw.fsf-monnier+emacs@gnu.org>
[not found] ` <<<<i2ehhdaxnq.fsf@fencepost.gnu.org>
[not found] ` <<<<jwv1udd2gab.fsf-monnier+emacs@gnu.org>
[not found] ` <<<<CADwFkm=SDc3obOA_KXvtWOBRay+aWtnOtkKX5SGPwXGVB=+hYg@mail.gmail.com>
[not found] ` <<<<83mu2objro.fsf@gnu.org>
[not found] ` <<<<CADwFkmnf6ch6CBN13opEWDVnZYY-TaT236xg21Qg2KjWuUVz+w@mail.gmail.com>
[not found] ` <<<<83imdcbgc5.fsf@gnu.org>
[not found] ` <<<<CADwFkm=V7cUz2_5Xr8=k6EZbFK96pJu8wpo6uAA+H7ABDYdH0w@mail.gmail.com>
[not found] ` <<<<83imcspim8.fsf@gnu.org>
[not found] ` <<<3aad96d8-2503-40e8-b684-8ed18a089083@default>
[not found] ` <<<83a6y4p98g.fsf@gnu.org>
[not found] ` <<7cfc062e-05b2-43f1-8714-19ebd955b88c@default>
[not found] ` <<837dt8p74z.fsf@gnu.org>
2020-09-05 15:46 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mu2objro.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=13521@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=rgm@gnu.org \
--cc=stefan@marxist.se \
--cc=xfq.free@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).