From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#13521: `sort-lines' on the empty region Date: Fri, 21 Aug 2020 09:22:35 +0300 Message-ID: <83mu2objro.fsf@gnu.org> References: <20130122085354.75ced82538551655e724e0ea@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35784"; mail-complaints-to="usenet@ciao.gmane.io" Cc: xfq.free@gmail.com, rgm@gnu.org, monnier@iro.umontreal.ca, 13521@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 21 08:23:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k90SG-0009Ba-MS for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Aug 2020 08:23:12 +0200 Original-Received: from localhost ([::1]:36636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k90SE-0008Lz-4b for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Aug 2020 02:23:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39162) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k90S6-0008Lp-4U for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2020 02:23:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33248) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k90S5-0007NR-RZ for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2020 02:23:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k90S5-0007aq-M5 for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2020 02:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Aug 2020 06:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13521 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13521-submit@debbugs.gnu.org id=B13521.159799097429172 (code B ref 13521); Fri, 21 Aug 2020 06:23:01 +0000 Original-Received: (at 13521) by debbugs.gnu.org; 21 Aug 2020 06:22:54 +0000 Original-Received: from localhost ([127.0.0.1]:44794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k90Rx-0007aR-Re for submit@debbugs.gnu.org; Fri, 21 Aug 2020 02:22:54 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k90Rt-0007aA-Tx for 13521@debbugs.gnu.org; Fri, 21 Aug 2020 02:22:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55366) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k90Ro-0007MY-1N; Fri, 21 Aug 2020 02:22:44 -0400 Original-Received: from [176.228.60.248] (port=4218 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k90Rl-0002WN-Nb; Fri, 21 Aug 2020 02:22:42 -0400 In-Reply-To: (message from Stefan Kangas on Thu, 20 Aug 2020 18:18:34 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185813 Archived-At: > From: Stefan Kangas > Date: Thu, 20 Aug 2020 18:18:34 -0700 > Cc: Xue Fuqiao , Glenn Morris , > 13521@debbugs.gnu.org > > > I personally prefer the "whole buffer", but whoever makes the change > > gets to make the choice. > > The attached patch makes 'sort-lines' sort the entire buffer when there > is no region. How frequently did you see a buffer in Emacs with no region in it? IME, it takes about 2 commands since buffer creation to have a region in it. So I predict users to be tripped by this feature quite a lot: they will think there's no region, invoke the command, and get some arbitrary region sorted. Requiring them to always provide the region avoids this pitfall, since the user is forced to make sure the region is where he or she wants it. And marking the whole buffer is just 2 key-presses away. So I think this change will annoy more than help.