From: Eli Zaretskii <eliz@gnu.org>
To: Aaron Jensen <aaronjensen@gmail.com>
Cc: 63988@debbugs.gnu.org
Subject: bug#63988: 30.0.50; Recent header line format changes cause spin/seg fault with format-mode-line
Date: Sat, 10 Jun 2023 16:04:40 +0300 [thread overview]
Message-ID: <83mt17zcwn.fsf@gnu.org> (raw)
In-Reply-To: <CAHyO48w24de0q-OjJvEY8X94Cqgi55hx73d4dZwUhvOvjv4HNw@mail.gmail.com> (message from Aaron Jensen on Sat, 10 Jun 2023 07:59:30 -0400)
> From: Aaron Jensen <aaronjensen@gmail.com>
> Date: Sat, 10 Jun 2023 07:59:30 -0400
> Cc: 63988@debbugs.gnu.org
>
> > > > So maybe we should declare this feature a failed experiment and remove
> > > > it?
> > >
> > > I'll admit I don't really understand the change. Is it actually
> > > evaluating the cdr of the eval form up to two additional times to in
> > > order to determine whether or not to display the headerline at all?
> >
> > Only two?
>
> Well, 2 per render. I'm just guessing at reading the diff.
window_wants_header_line is called in many other places as well.
> I'd personally prefer performance to being able to hide the header
> line optionally
What's wrong with setting header-line-format to nil?
> though I still don't really understand the change and
> why the one time it's eval'd in order to get the actual text/format
> can't be used to determine whether or not to show the header line.
Mainly because the window layout decisions need to know whether there
will be a header line before it's actually displayed.
next prev parent reply other threads:[~2023-06-10 13:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-10 1:09 bug#63988: 30.0.50; Recent header line format changes cause spin/seg fault with format-mode-line Aaron Jensen
2023-06-10 6:47 ` Eli Zaretskii
2023-06-10 8:56 ` Eli Zaretskii
2023-06-10 9:07 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-15 5:59 ` Eli Zaretskii
2023-06-16 2:30 ` Aaron Jensen
2023-06-23 10:53 ` Eli Zaretskii
2023-07-05 15:30 ` Spencer Baugh
2023-07-05 15:40 ` Eli Zaretskii
2023-06-10 16:16 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-10 17:42 ` Eli Zaretskii
2023-06-10 17:51 ` Aaron Jensen
2023-06-10 19:11 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-10 11:08 ` Aaron Jensen
2023-06-10 11:22 ` Eli Zaretskii
2023-06-10 11:59 ` Aaron Jensen
2023-06-10 13:04 ` Eli Zaretskii [this message]
2023-06-10 15:06 ` Aaron Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mt17zcwn.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=63988@debbugs.gnu.org \
--cc=aaronjensen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).