From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63988: 30.0.50; Recent header line format changes cause spin/seg fault with format-mode-line Date: Sat, 10 Jun 2023 16:04:40 +0300 Message-ID: <83mt17zcwn.fsf@gnu.org> References: <831qij24qm.fsf@gnu.org> <83o7lnzhm5.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6954"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63988@debbugs.gnu.org To: Aaron Jensen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 10 15:05:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q7yHP-0001ZQ-Qo for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Jun 2023 15:05:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q7yHE-0008Gh-Rx; Sat, 10 Jun 2023 09:05:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7yH8-0008GE-Qg for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2023 09:05:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q7yH8-0002Ap-BL for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2023 09:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q7yH7-0003IT-Ro for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2023 09:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Jun 2023 13:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63988 X-GNU-PR-Package: emacs Original-Received: via spool by 63988-submit@debbugs.gnu.org id=B63988.168640228012637 (code B ref 63988); Sat, 10 Jun 2023 13:05:01 +0000 Original-Received: (at 63988) by debbugs.gnu.org; 10 Jun 2023 13:04:40 +0000 Original-Received: from localhost ([127.0.0.1]:33416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7yGl-0003Hl-Lo for submit@debbugs.gnu.org; Sat, 10 Jun 2023 09:04:39 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7yGh-0003HR-IK for 63988@debbugs.gnu.org; Sat, 10 Jun 2023 09:04:39 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7yGb-00023C-Uh; Sat, 10 Jun 2023 09:04:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/V3m+9Q/pj/TLaxOgAmsMR30EuE5eUOZfrvAOVs9N2k=; b=X8ykkS2D9xJn XXsaB7OA4T0ThBZAQogYKXlbfrSNSVTrQklI8Pekh1TQ2Sgfxzs/R4/zZbPH1nzG4cXrIFWgSRfF2 KjvWQ4b3XtBJKOmQZWwsn4qofV5qD/gRUJGKS4H/6Sv9Y0mq5ulh9F6sXI/eqog3z4BEx0rqGJ92W uZXVM6lJy2D3qjwJxgYfpS2haimZt3dPALvqG2j2KZOKWhQzALRVEX/9aq7Esjo4UW7qaAUKWRguh c/kfkyfPja/4TWmq9dAlLrNJucUjr0x4ERQ69GbVQPM3eBOom2Bv9p5cyGUBulhBiXRFt+wXivGZD TeXV6wuhNtmRrZ7csA2Swg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7yGb-0004Wz-Ef; Sat, 10 Jun 2023 09:04:29 -0400 In-Reply-To: (message from Aaron Jensen on Sat, 10 Jun 2023 07:59:30 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263216 Archived-At: > From: Aaron Jensen > Date: Sat, 10 Jun 2023 07:59:30 -0400 > Cc: 63988@debbugs.gnu.org > > > > > So maybe we should declare this feature a failed experiment and remove > > > > it? > > > > > > I'll admit I don't really understand the change. Is it actually > > > evaluating the cdr of the eval form up to two additional times to in > > > order to determine whether or not to display the headerline at all? > > > > Only two? > > Well, 2 per render. I'm just guessing at reading the diff. window_wants_header_line is called in many other places as well. > I'd personally prefer performance to being able to hide the header > line optionally What's wrong with setting header-line-format to nil? > though I still don't really understand the change and > why the one time it's eval'd in order to get the actual text/format > can't be used to determine whether or not to show the header line. Mainly because the window layout decisions need to know whether there will be a header line before it's actually displayed.