From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: handa@gnu.org, eggert@cs.ucla.edu, 8215@debbugs.gnu.org
Subject: bug#8215: possibly uninitialized variable lower_xoff in produce_glyphless_glyph
Date: Sun, 06 Jun 2021 12:13:41 +0300 [thread overview]
Message-ID: <83lf7nice2.fsf@gnu.org> (raw)
In-Reply-To: <87wnr7v04r.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 06 Jun 2021 11:00:04 +0200)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: eggert@cs.ucla.edu, 8215@debbugs.gnu.org, Kenichi Handa <handa@gnu.org>
> Date: Sun, 06 Jun 2021 11:00:04 +0200
>
> Nice catch. :-) I tried reading that function for a couple of minutes
> to try to make sense how lower_xoff should have been initialised, but I
> had to admit defeat.
The reason we didn't have the fix earlier is that the problem is only
visible when the default face's font is variable-pitch, otherwise the
offending code is never executed. So it was hard to understand what
that "workaround" initialization caused.
Let me know if I should add some comments there to make the code's
intent and purpose more clear.
prev parent reply other threads:[~2021-06-06 9:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 22:00 bug#8215: possibly uninitialized variable lower_xoff in produce_glyphless_glyph Paul Eggert
2021-06-02 8:06 ` Lars Ingebrigtsen
2021-06-02 13:17 ` Eli Zaretskii
2021-06-06 9:00 ` Lars Ingebrigtsen
2021-06-06 9:13 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lf7nice2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=8215@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=handa@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).