From: Paul Eggert <eggert@cs.ucla.edu>
To: 8215@debbugs.gnu.org
Subject: bug#8215: possibly uninitialized variable lower_xoff in produce_glyphless_glyph
Date: Wed, 09 Mar 2011 14:00:12 -0800 [thread overview]
Message-ID: <4D77F86C.9080809@cs.ucla.edu> (raw)
I found this problem by compiling Emacs with GCC's -Wuninitialized flag.
The following code in the Emacs trunk src/xdisp.c's
produce_glyphless_glyph function might be using an uninitialized
variable:
if (base_width >= width)
{
/* Align the upper to the left, the lower to the right. */
it->pixel_width = base_width;
lower_xoff = base_width - 2 - metrics_lower.width;
}
else
{
/* Center the shorter one. */
it->pixel_width = width;
if (metrics_upper.width >= metrics_lower.width)
lower_xoff = (width - metrics_lower.width) / 2;
else
upper_xoff = (width - metrics_upper.width) / 2;
}
...
if (it->glyph_row)
append_glyphless_glyph (it, face_id, for_no_font, len,
upper_xoff, upper_yoff,
lower_xoff, lower_yoff);
The last call uses lower_xoff, but the last "else" does not initialize
lower_xoff. The bug cannot occur if it->glyph_row is NULL, but I
don't see why that would necessarily be. So I'm filing a bug report
so that someone who is more expert in this code can take a look at it.
In the meantime, I plan to work around the problem by initializing
lower_xoff to 0, with a FIXME explaining the situation: this shouldn't
introduce a bug, because at worst it will replace undefined behavior
with defined behavior.
I'm CC'ing this to Kenichi Handa, who committed the code in question.
next reply other threads:[~2011-03-09 22:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 22:00 Paul Eggert [this message]
2021-06-02 8:06 ` bug#8215: possibly uninitialized variable lower_xoff in produce_glyphless_glyph Lars Ingebrigtsen
2021-06-02 13:17 ` Eli Zaretskii
2021-06-06 9:00 ` Lars Ingebrigtsen
2021-06-06 9:13 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D77F86C.9080809@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=8215@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).