From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#8215: possibly uninitialized variable lower_xoff in produce_glyphless_glyph Date: Sun, 06 Jun 2021 12:13:41 +0300 Message-ID: <83lf7nice2.fsf@gnu.org> References: <4D77F86C.9080809@cs.ucla.edu> <87k0ncelmi.fsf@gnus.org> <83sg20xv6w.fsf@gnu.org> <87wnr7v04r.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28689"; mail-complaints-to="usenet@ciao.gmane.io" Cc: handa@gnu.org, eggert@cs.ucla.edu, 8215@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 06 11:14:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lporG-0007DR-9I for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Jun 2021 11:14:14 +0200 Original-Received: from localhost ([::1]:45778 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lporF-0000IZ-AZ for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Jun 2021 05:14:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35578) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpor4-0000HC-EK for bug-gnu-emacs@gnu.org; Sun, 06 Jun 2021 05:14:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39088) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lpor4-0000Ku-8C for bug-gnu-emacs@gnu.org; Sun, 06 Jun 2021 05:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lpor4-0005PZ-4S for bug-gnu-emacs@gnu.org; Sun, 06 Jun 2021 05:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Jun 2021 09:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8215 X-GNU-PR-Package: emacs Original-Received: via spool by 8215-submit@debbugs.gnu.org id=B8215.162297083620780 (code B ref 8215); Sun, 06 Jun 2021 09:14:02 +0000 Original-Received: (at 8215) by debbugs.gnu.org; 6 Jun 2021 09:13:56 +0000 Original-Received: from localhost ([127.0.0.1]:50634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpoqy-0005P6-9c for submit@debbugs.gnu.org; Sun, 06 Jun 2021 05:13:56 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpoqt-0005Oq-HU for 8215@debbugs.gnu.org; Sun, 06 Jun 2021 05:13:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46594) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpoqn-00008B-F7; Sun, 06 Jun 2021 05:13:45 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4372 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpoqn-0000y2-2O; Sun, 06 Jun 2021 05:13:45 -0400 In-Reply-To: <87wnr7v04r.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 06 Jun 2021 11:00:04 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208100 Archived-At: > From: Lars Ingebrigtsen > Cc: eggert@cs.ucla.edu, 8215@debbugs.gnu.org, Kenichi Handa > Date: Sun, 06 Jun 2021 11:00:04 +0200 > > Nice catch. :-) I tried reading that function for a couple of minutes > to try to make sense how lower_xoff should have been initialised, but I > had to admit defeat. The reason we didn't have the fix earlier is that the problem is only visible when the default face's font is variable-pitch, otherwise the offending code is never executed. So it was hard to understand what that "workaround" initialization caused. Let me know if I should add some comments there to make the code's intent and purpose more clear.