From: Eli Zaretskii <eliz@gnu.org>
To: Alan Mackenzie <acm@muc.de>
Cc: 50946@debbugs.gnu.org, joaotavora@gmail.com
Subject: bug#50946: Emacs-28: Inadequate coding in hack-elisp-shorthands
Date: Sat, 02 Oct 2021 17:19:17 +0300 [thread overview]
Message-ID: <83k0ivbjbu.fsf@gnu.org> (raw)
In-Reply-To: <YVhlQWYSJXniDUeC@ACM> (message from Alan Mackenzie on Sat, 2 Oct 2021 13:57:21 +0000)
> Date: Sat, 2 Oct 2021 13:57:21 +0000
> Cc: joaotavora@gmail.com, 50946@debbugs.gnu.org
> From: Alan Mackenzie <acm@muc.de>
>
> > If you want me to take your critique seriously, please be specific:
> > what are the aspects of that function that you think lack attention to
> > detail, and what detail?
>
> The five aspects I enumerated on my original bug report. Not checking
> for a properly formatted Local Variables: section
That is not part of the function in question, is it? It's in
hack-local-variables--find-variables, which we use everywhere.
> not checking for lower-case in that variable being searched for
That's also in hack-local-variables--find-variables, right?
> not going back at least 3000 characters
That is now fixed, right?
> Additionally, the original code didn't check for a page boundary.
No longer relevant, right?
> What worries me is that this lack of attention to detail might extend to
> the new code in lread.c, or the documentation page.
You are welcome to point out specific issues with that.
> I still think somebody who isn't João and isn't me should check
> this.
I did that when reviewing the commit.
> I worry, to a lesser degree, it is not entirely clear whether setting
> the elisp-shorthands variable in the first line of a short file should
> be valid or not. I don't think the current hack-elisp-shorthands is
> careful enough about this.
Why does it matter?
> > And while at that, please try to distinguish between general problems
> > of hack-local-variables--find-variables, which affect all of Emacs,
> > and hack-elisp-shorthands, which is specific to this feature.
>
> I think all the things I've said in this bug report are about
> hack-elisp-shorthands and the other new code/doc in this feature.
See above: I don't think I agree.
> > So the invitation to calm down goes both ways here. Please focus on
> > technical issues and leave ad-hominem out of this, okay?
>
> Is this bug to be fixed completely, or are the edge cases just to be
> ignored as unimportant? That is the current technical issue as I see
> it. I really don't want to fix the bug myself, but am prepared to do so
> if nobody else is. If you think the bug indeed needs completely fixing,
> please reopen it - there's no point in me trying to reopen it again. If
> you don't, just leave things the way they are.
Please forget what happened before, and let's pick up from the above
points I mention. What else needs to be fixed in shorthands.el, and
why?
next prev parent reply other threads:[~2021-10-02 14:19 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 17:10 bug#50946: Emacs-28: Inadequate coding in hack-elisp-shorthands Alan Mackenzie
2021-10-01 17:53 ` Eli Zaretskii
2021-10-01 21:15 ` João Távora
2021-10-02 6:10 ` Eli Zaretskii
2021-10-02 0:48 ` João Távora
2021-10-02 10:50 ` Alan Mackenzie
2021-10-02 11:13 ` João Távora
2021-10-02 11:38 ` João Távora
2021-10-02 12:38 ` Alan Mackenzie
2021-10-02 12:52 ` Eli Zaretskii
2021-10-02 13:57 ` Alan Mackenzie
2021-10-02 14:19 ` Eli Zaretskii [this message]
2021-10-02 14:45 ` Alan Mackenzie
2021-10-02 15:00 ` Eli Zaretskii
2021-10-02 20:07 ` Alan Mackenzie
2021-10-03 11:45 ` Eli Zaretskii
2021-10-03 12:10 ` bug#50946: insert-file-contents can corrupt buffers. [Was: bug#50946: Emacs-28: Inadequate coding in hack-elisp-shorthands] Alan Mackenzie
2021-10-03 12:40 ` Eli Zaretskii
2021-10-03 13:33 ` Alan Mackenzie
2021-10-03 15:04 ` bug#50946: insert-file-contents can corrupt buffers Alan Mackenzie
2021-10-03 15:25 ` Eli Zaretskii
2021-10-03 17:21 ` Alan Mackenzie
2021-10-03 17:36 ` Eli Zaretskii
2021-10-03 18:19 ` Alan Mackenzie
2021-10-03 15:34 ` bug#50946: insert-file-contents can corrupt buffers. [Was: bug#50946: Emacs-28: Inadequate coding in hack-elisp-shorthands] João Távora
2021-10-03 15:42 ` João Távora
2021-10-03 15:56 ` Eli Zaretskii
2021-10-03 16:02 ` João Távora
2021-10-03 16:20 ` Eli Zaretskii
2021-10-03 17:05 ` João Távora
2021-10-03 17:56 ` Eli Zaretskii
2021-10-03 18:59 ` João Távora
2021-10-03 19:51 ` Eli Zaretskii
2021-10-03 19:59 ` João Távora
2021-10-02 15:02 ` bug#50946: Emacs-28: Inadequate coding in hack-elisp-shorthands João Távora
2021-10-04 0:14 ` Richard Stallman
2021-10-02 14:47 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k0ivbjbu.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=50946@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).