From: Eli Zaretskii <eliz@gnu.org>
To: Alan Mackenzie <acm@muc.de>
Cc: 50946@debbugs.gnu.org, joaotavora@gmail.com
Subject: bug#50946: Emacs-28: Inadequate coding in hack-elisp-shorthands
Date: Sun, 03 Oct 2021 14:45:14 +0300 [thread overview]
Message-ID: <83r1d28h85.fsf@gnu.org> (raw)
In-Reply-To: <YVi7/pbufFHPjZh6@ACM> (message from Alan Mackenzie on Sat, 2 Oct 2021 20:07:26 +0000)
> Date: Sat, 2 Oct 2021 20:07:26 +0000
> Cc: joaotavora@gmail.com, 50946@debbugs.gnu.org
> From: Alan Mackenzie <acm@muc.de>
>
> > > > > not going back at least 3000 characters
>
> > > > That is now fixed, right?
>
> > > No, it's not. In certain edge cases, it will go back fewer than 3000
> > > characters.
>
> > Does the patch below solve this?
>
> I think it does, yes. Thanks!
Now installed.
> > > > > I worry, to a lesser degree, it is not entirely clear whether setting
> > > > > the elisp-shorthands variable in the first line of a short file should
> > > > > be valid or not. I don't think the current hack-elisp-shorthands is
> > > > > careful enough about this.
>
> > > > Why does it matter?
>
> Otherwise we could have the scenario where somebody sets elisp-shorthands
> in the first line of a file, finds it works, then types more into the
> file, saves the buffer, then finds when she visits the file again that it
> no longer works. This, I think, would be a Bad Thing.
I'm not sure. If the user doesn't obey the rules, the user gets
amply punished.
> > > Because the first line definition should either be valid or not valid.
> > > Currently it works for a sufficiently small file, but not for a normal
> > > sized file. This, I think, is a bug.
>
> > No, I don't think it's a bug, at least not a bug specific to
> > shorthands. That's how file-local variables work in general.
>
> No, not quite. For normal file-local variables, having one set in the
> first line works regardless of the length of the file. It wouldn't for
> elisp-shorthands, where it would only work for short files.
I don't think I follow. can you show an example of a problematic
file, so that we are sure we are talking about the same issue?
> > > Have you checked that things work if the first byte in your temporary
> > > buffer isn't at the start of a character?
>
> > I don't see why this matters, can you explain?
>
> It might matter, I simply don't know. I rarely type characters into
> Emacs which are longer than a single byte in UTF8. I don't know whether
> insert-file-contents does the Right Thing when there's half a character
> at point-min, then insert-file-contents inserts the other half of the
> character before it.
The character read in separate parts will indeed be incorrect, but how
does this affect searching for the local-variables section? I don't
think it does, because there are only ASCII characters in the header
of that section.
> I don't know to what extent normal Emacs functions
> work when there are invalid "characters" at point-min or point-max.
They aren't invalid characters, they are raw 8-bit bytes. Emacs
search functions can cope with them without a problem.
next prev parent reply other threads:[~2021-10-03 11:45 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 17:10 bug#50946: Emacs-28: Inadequate coding in hack-elisp-shorthands Alan Mackenzie
2021-10-01 17:53 ` Eli Zaretskii
2021-10-01 21:15 ` João Távora
2021-10-02 6:10 ` Eli Zaretskii
2021-10-02 0:48 ` João Távora
2021-10-02 10:50 ` Alan Mackenzie
2021-10-02 11:13 ` João Távora
2021-10-02 11:38 ` João Távora
2021-10-02 12:38 ` Alan Mackenzie
2021-10-02 12:52 ` Eli Zaretskii
2021-10-02 13:57 ` Alan Mackenzie
2021-10-02 14:19 ` Eli Zaretskii
2021-10-02 14:45 ` Alan Mackenzie
2021-10-02 15:00 ` Eli Zaretskii
2021-10-02 20:07 ` Alan Mackenzie
2021-10-03 11:45 ` Eli Zaretskii [this message]
2021-10-03 12:10 ` bug#50946: insert-file-contents can corrupt buffers. [Was: bug#50946: Emacs-28: Inadequate coding in hack-elisp-shorthands] Alan Mackenzie
2021-10-03 12:40 ` Eli Zaretskii
2021-10-03 13:33 ` Alan Mackenzie
2021-10-03 15:04 ` bug#50946: insert-file-contents can corrupt buffers Alan Mackenzie
2021-10-03 15:25 ` Eli Zaretskii
2021-10-03 17:21 ` Alan Mackenzie
2021-10-03 17:36 ` Eli Zaretskii
2021-10-03 18:19 ` Alan Mackenzie
2021-10-03 15:34 ` bug#50946: insert-file-contents can corrupt buffers. [Was: bug#50946: Emacs-28: Inadequate coding in hack-elisp-shorthands] João Távora
2021-10-03 15:42 ` João Távora
2021-10-03 15:56 ` Eli Zaretskii
2021-10-03 16:02 ` João Távora
2021-10-03 16:20 ` Eli Zaretskii
2021-10-03 17:05 ` João Távora
2021-10-03 17:56 ` Eli Zaretskii
2021-10-03 18:59 ` João Távora
2021-10-03 19:51 ` Eli Zaretskii
2021-10-03 19:59 ` João Távora
2021-10-02 15:02 ` bug#50946: Emacs-28: Inadequate coding in hack-elisp-shorthands João Távora
2021-10-04 0:14 ` Richard Stallman
2021-10-02 14:47 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r1d28h85.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=50946@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).