From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50946: Emacs-28: Inadequate coding in hack-elisp-shorthands Date: Sat, 02 Oct 2021 17:19:17 +0300 Message-ID: <83k0ivbjbu.fsf@gnu.org> References: <831r54einq.fsf@gnu.org> <871r54xnds.fsf@gmail.com> <87ee933bcj.fsf@gmail.com> <83pmsnbnci.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38549"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50946@debbugs.gnu.org, joaotavora@gmail.com To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 02 16:20:27 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mWfsI-0009jt-Uh for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Oct 2021 16:20:26 +0200 Original-Received: from localhost ([::1]:34856 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWfsH-0002GK-Tm for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Oct 2021 10:20:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45996) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWfru-0002Db-Vd for bug-gnu-emacs@gnu.org; Sat, 02 Oct 2021 10:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48616) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mWfru-0006PS-Nu for bug-gnu-emacs@gnu.org; Sat, 02 Oct 2021 10:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mWfru-0004Gl-Ei for bug-gnu-emacs@gnu.org; Sat, 02 Oct 2021 10:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Oct 2021 14:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50946 X-GNU-PR-Package: emacs Original-Received: via spool by 50946-submit@debbugs.gnu.org id=B50946.163318438216382 (code B ref 50946); Sat, 02 Oct 2021 14:20:02 +0000 Original-Received: (at 50946) by debbugs.gnu.org; 2 Oct 2021 14:19:42 +0000 Original-Received: from localhost ([127.0.0.1]:60162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWfra-0004G9-Cp for submit@debbugs.gnu.org; Sat, 02 Oct 2021 10:19:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWfrY-0004Fv-RH for 50946@debbugs.gnu.org; Sat, 02 Oct 2021 10:19:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53808) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWfrS-00066C-VY; Sat, 02 Oct 2021 10:19:34 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1329 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWfrS-00054d-Ii; Sat, 02 Oct 2021 10:19:34 -0400 In-Reply-To: (message from Alan Mackenzie on Sat, 2 Oct 2021 13:57:21 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216156 Archived-At: > Date: Sat, 2 Oct 2021 13:57:21 +0000 > Cc: joaotavora@gmail.com, 50946@debbugs.gnu.org > From: Alan Mackenzie > > > If you want me to take your critique seriously, please be specific: > > what are the aspects of that function that you think lack attention to > > detail, and what detail? > > The five aspects I enumerated on my original bug report. Not checking > for a properly formatted Local Variables: section That is not part of the function in question, is it? It's in hack-local-variables--find-variables, which we use everywhere. > not checking for lower-case in that variable being searched for That's also in hack-local-variables--find-variables, right? > not going back at least 3000 characters That is now fixed, right? > Additionally, the original code didn't check for a page boundary. No longer relevant, right? > What worries me is that this lack of attention to detail might extend to > the new code in lread.c, or the documentation page. You are welcome to point out specific issues with that. > I still think somebody who isn't Joćo and isn't me should check > this. I did that when reviewing the commit. > I worry, to a lesser degree, it is not entirely clear whether setting > the elisp-shorthands variable in the first line of a short file should > be valid or not. I don't think the current hack-elisp-shorthands is > careful enough about this. Why does it matter? > > And while at that, please try to distinguish between general problems > > of hack-local-variables--find-variables, which affect all of Emacs, > > and hack-elisp-shorthands, which is specific to this feature. > > I think all the things I've said in this bug report are about > hack-elisp-shorthands and the other new code/doc in this feature. See above: I don't think I agree. > > So the invitation to calm down goes both ways here. Please focus on > > technical issues and leave ad-hominem out of this, okay? > > Is this bug to be fixed completely, or are the edge cases just to be > ignored as unimportant? That is the current technical issue as I see > it. I really don't want to fix the bug myself, but am prepared to do so > if nobody else is. If you think the bug indeed needs completely fixing, > please reopen it - there's no point in me trying to reopen it again. If > you don't, just leave things the way they are. Please forget what happened before, and let's pick up from the above points I mention. What else needs to be fixed in shorthands.el, and why?