From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: yasu@utahime.org, 55386@debbugs.gnu.org
Subject: bug#55386: 29.0.50; check-declare-directory doesn't work on Windows
Date: Sat, 14 May 2022 15:05:56 +0300 [thread overview]
Message-ID: <83k0aol3ob.fsf@gnu.org> (raw)
In-Reply-To: <87lev4l4v8.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 14 May 2022 13:40:11 +0200)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: yasu@utahime.org, 55386@debbugs.gnu.org
> Date: Sat, 14 May 2022 13:40:11 +0200
>
> > - (let ((files (process-lines-ignore-status
> > - find-program root
> > - "-name" "*.el"
> > - "-exec" grep-program
> > - "-l" "^[ \t]*(declare-function" "{}" "+")))
> > + (let ((files (directory-files-recursively root "\\.el\\'")))
> > (when files
> > (apply #'check-declare-files files))))
>
> I'm surprised that it's just 9% slower -- there's 2K files in the Emacs
> tree, and only one a quarter of them have a declare-function. Is
> process-lines-ignore-status really slow or something?
I don't know if it's really slow, but it runs Grep on each file, and
that slows down the command it launches. directory-files-recursively
is much faster, but then check-declare-files has more files to check.
I think the slowdown depends on the system and on the build. I only
tested in unoptimized builds, and the GNU/Linux system to which I have
access is a relatively slow VM. So maybe you should time this
yourself before we decide whether the slow-down is acceptable?
Or what kind of slow-down can we endure before we feel uneasy about
the change?
> But the change looks fine to me in any case.
I can install now if you are okay with the above.
next prev parent reply other threads:[~2022-05-14 12:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 15:22 bug#55386: 29.0.50; check-declare-directory doesn't work on Windows Yasuhiro Kimura
2022-05-12 15:57 ` Lars Ingebrigtsen
2022-05-12 16:43 ` Eli Zaretskii
2022-05-13 12:21 ` Lars Ingebrigtsen
2022-05-13 12:35 ` Eli Zaretskii
2022-05-13 15:46 ` Lars Ingebrigtsen
2022-05-14 9:09 ` Eli Zaretskii
2022-05-14 11:40 ` Lars Ingebrigtsen
2022-05-14 12:05 ` Eli Zaretskii [this message]
2022-05-14 15:36 ` Lars Ingebrigtsen
2022-05-14 16:09 ` Eli Zaretskii
2022-05-14 13:27 ` Eli Zaretskii
2022-05-14 13:39 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-14 13:44 ` Eli Zaretskii
2022-05-14 15:37 ` Lars Ingebrigtsen
2022-05-14 16:34 ` Eli Zaretskii
2022-05-12 17:35 ` Yasuhiro Kimura
2022-05-13 12:25 ` Lars Ingebrigtsen
2022-05-13 12:31 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k0aol3ob.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=55386@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=yasu@utahime.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).