unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: larsi@gnus.org, Po Lu <luangruo@yahoo.com>
Cc: yasu@utahime.org, 55386@debbugs.gnu.org
Subject: bug#55386: 29.0.50; check-declare-directory doesn't work on Windows
Date: Sat, 14 May 2022 16:27:02 +0300	[thread overview]
Message-ID: <83ilq8kzx5.fsf@gnu.org> (raw)
In-Reply-To: <83o800lbtn.fsf@gnu.org> (message from Eli Zaretskii on Sat, 14 May 2022 12:09:56 +0300)

> Cc: yasu@utahime.org, 55386@debbugs.gnu.org
> Date: Sat, 14 May 2022 12:09:56 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > (Hm...  it finds over a 100 in-tree declarations that it says are
> > malformed/wrong...  Perhaps somebody should have a look at that.)
> 
> Yes, please.

I've now fixed many of those.  The ones left are:

  . those from Org -- should be fixed in Org repository
  . references to packages not in core (like BBDB and W3M)
  . stuff that _looks_ like functions, but isn't: compiler-macros,
    constructors, games we play with setf etc. -- this is where
    check-declare "Needs Work"(TM) to be smarter

There are two warnings regarding PGTK which I didn't know what to do
about:

  lisp/frame.el:1996:Warning (check-declare): said ‘pgtk-frame-list-z-order’ was
      defined in src/pgtkfns.c: function not found

  lisp/term/pgtk-win.el:48:Warning (check-declare): said ‘pgtk-hide-emacs’ was
      defined in src/pgtkfns.c: function not found

Those functions indeed don't exist, AFAICT, but they _are_ called from
Lisp.  Po Lu, can you please DTRT there?





  parent reply	other threads:[~2022-05-14 13:27 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-12 15:22 bug#55386: 29.0.50; check-declare-directory doesn't work on Windows Yasuhiro Kimura
2022-05-12 15:57 ` Lars Ingebrigtsen
2022-05-12 16:43   ` Eli Zaretskii
2022-05-13 12:21     ` Lars Ingebrigtsen
2022-05-13 12:35       ` Eli Zaretskii
2022-05-13 15:46         ` Lars Ingebrigtsen
2022-05-14  9:09           ` Eli Zaretskii
2022-05-14 11:40             ` Lars Ingebrigtsen
2022-05-14 12:05               ` Eli Zaretskii
2022-05-14 15:36                 ` Lars Ingebrigtsen
2022-05-14 16:09                   ` Eli Zaretskii
2022-05-14 13:27             ` Eli Zaretskii [this message]
2022-05-14 13:39               ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-14 13:44                 ` Eli Zaretskii
2022-05-14 15:37               ` Lars Ingebrigtsen
2022-05-14 16:34                 ` Eli Zaretskii
2022-05-12 17:35   ` Yasuhiro Kimura
2022-05-13 12:25     ` Lars Ingebrigtsen
2022-05-13 12:31       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ilq8kzx5.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=55386@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=luangruo@yahoo.com \
    --cc=yasu@utahime.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).