From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#55386: 29.0.50; check-declare-directory doesn't work on Windows Date: Sat, 14 May 2022 15:05:56 +0300 Message-ID: <83k0aol3ob.fsf@gnu.org> References: <20220513.002244.1042559713148422728.yasu@utahime.org> <878rr6ycaa.fsf@gnus.org> <835ymapupz.fsf@gnu.org> <878rr5wrma.fsf@gnus.org> <83pmkhmwyv.fsf@gnu.org> <87a6bl305x.fsf@gnus.org> <83o800lbtn.fsf@gnu.org> <87lev4l4v8.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1351"; mail-complaints-to="usenet@ciao.gmane.io" Cc: yasu@utahime.org, 55386@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 14 14:07:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1npqYA-00006b-OW for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 May 2022 14:07:10 +0200 Original-Received: from localhost ([::1]:56946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1npqY9-0008Mj-BL for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 May 2022 08:07:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npqY2-0008Mb-LW for bug-gnu-emacs@gnu.org; Sat, 14 May 2022 08:07:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52053) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1npqY2-0000HN-CD for bug-gnu-emacs@gnu.org; Sat, 14 May 2022 08:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1npqY2-0004V4-3Z for bug-gnu-emacs@gnu.org; Sat, 14 May 2022 08:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 May 2022 12:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55386 X-GNU-PR-Package: emacs Original-Received: via spool by 55386-submit@debbugs.gnu.org id=B55386.165252998117239 (code B ref 55386); Sat, 14 May 2022 12:07:02 +0000 Original-Received: (at 55386) by debbugs.gnu.org; 14 May 2022 12:06:21 +0000 Original-Received: from localhost ([127.0.0.1]:45950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npqXE-0004Tl-6G for submit@debbugs.gnu.org; Sat, 14 May 2022 08:06:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npqXC-0004TY-DT for 55386@debbugs.gnu.org; Sat, 14 May 2022 08:06:10 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53770) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npqX6-0008SK-Vu; Sat, 14 May 2022 08:06:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=lr/hTW+ySujVibeVE3EXvS6c8mXPnPusnGSeK8rELIg=; b=K0WmWkqVTJtB jcVb97F1mvi0/RdGUp/drFT0r1qY1/Ecv33dK3TA8jmDVpL0Ap/FsU79mPhbFZ+4HKYsXDRSnjmKG ePt3Cmti5staDwPQJmjo61myOC9UV0IwivkUtY/kn99S/dtaPJYVcgjtuU4asQElucNh0H7b0ug+F eVf3+Pu8JthkwIZCvCK60SBTbeCIHD3Tno6B8FcZZLpQzSeQK9RI3madX6vE5sCLvAF8ZdPqux2JB lZhB/HzGUKekKiikOf0+kM5wX1g3OBse6Xjvc2vHIOoUquznJhTkfZOhc4E6BKl9B16p1869KiHKW 8pUEdUGImrV+02hoe77DUw==; Original-Received: from [87.69.77.57] (port=2813 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npqX6-000827-E3; Sat, 14 May 2022 08:06:04 -0400 In-Reply-To: <87lev4l4v8.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 14 May 2022 13:40:11 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:232232 Archived-At: > From: Lars Ingebrigtsen > Cc: yasu@utahime.org, 55386@debbugs.gnu.org > Date: Sat, 14 May 2022 13:40:11 +0200 > > > - (let ((files (process-lines-ignore-status > > - find-program root > > - "-name" "*.el" > > - "-exec" grep-program > > - "-l" "^[ \t]*(declare-function" "{}" "+"))) > > + (let ((files (directory-files-recursively root "\\.el\\'"))) > > (when files > > (apply #'check-declare-files files)))) > > I'm surprised that it's just 9% slower -- there's 2K files in the Emacs > tree, and only one a quarter of them have a declare-function. Is > process-lines-ignore-status really slow or something? I don't know if it's really slow, but it runs Grep on each file, and that slows down the command it launches. directory-files-recursively is much faster, but then check-declare-files has more files to check. I think the slowdown depends on the system and on the build. I only tested in unoptimized builds, and the GNU/Linux system to which I have access is a relatively slow VM. So maybe you should time this yourself before we decide whether the slow-down is acceptable? Or what kind of slow-down can we endure before we feel uneasy about the change? > But the change looks fine to me in any case. I can install now if you are okay with the above.