unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: ofv@wanadoo.es, 37802@debbugs.gnu.org
Subject: bug#37802: 27.0.50; Feature request: hook for theme enabling/disabling
Date: Sat, 21 May 2022 16:07:00 +0300	[thread overview]
Message-ID: <83k0af826j.fsf@gnu.org> (raw)
In-Reply-To: <871qwnyrgd.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat,  21 May 2022 14:56:34 +0200)

> Resent-From: Lars Ingebrigtsen <larsi@gnus.org>
> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
> Resent-CC: bug-gnu-emacs@gnu.org
> Resent-Sender: help-debbugs@gnu.org
> Cc: 37802@debbugs.gnu.org
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Sat, 21 May 2022 14:56:34 +0200
> 
> Óscar Fuentes <ofv@wanadoo.es> writes:
> 
> > Currently I've solved my requirement by using defadvice on enable-theme
> > *and* disable-theme for adapting my custom faces to changes on the
> > active theme(s). Using a hook would be a little bit cleaner. I'm also
> > surprised that no hook was implemented for this case, as most changes on
> > user-visible state has an associated hook.
> 
> Yes, true.  So I've now added these two hooks to Emacs 29.

Thanks, but is there any reason these hooks aren't called
enable-theme-function and disable-theme-function?  Hooks by such
names are already documented as "abnormal hooks", which would avoid
the need of saying these new hooks are "atypical", something that we
never had in our terminology.





  reply	other threads:[~2022-05-21 13:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-18  0:29 bug#37802: 27.0.50; Feature request: hook for theme enabling/disabling Óscar Fuentes
2022-05-20 10:58 ` Lars Ingebrigtsen
2022-05-20 14:51   ` Óscar Fuentes
2022-05-21 12:56     ` Lars Ingebrigtsen
2022-05-21 13:07       ` Eli Zaretskii [this message]
2022-05-21 13:21         ` Lars Ingebrigtsen
2022-05-21 13:25           ` Eli Zaretskii
2022-05-21 13:26             ` Lars Ingebrigtsen
2022-05-21 16:49       ` Óscar Fuentes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k0af826j.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=37802@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=ofv@wanadoo.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).