From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: ofv@wanadoo.es, 37802@debbugs.gnu.org
Subject: bug#37802: 27.0.50; Feature request: hook for theme enabling/disabling
Date: Sat, 21 May 2022 16:25:09 +0300 [thread overview]
Message-ID: <83ilpz81ca.fsf@gnu.org> (raw)
In-Reply-To: <87tu9jxbqe.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 21 May 2022 15:21:29 +0200)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: ofv@wanadoo.es, 37802@debbugs.gnu.org
> Date: Sat, 21 May 2022 15:21:29 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > Thanks, but is there any reason these hooks aren't called
> > enable-theme-function and disable-theme-function? Hooks by such
> > names are already documented as "abnormal hooks", which would avoid
> > the need of saying these new hooks are "atypical", something that we
> > never had in our terminology.
>
> "Abnormal" was the word I was looking for.
>
> As for the name, I don't really have much of an opinion -- we have more
> of these abnormal hooks called -hook than -function(s), a short grepping
> for run-hook-with-args shows.
Maybe so, and we cannot do much about bad names that are already in
the wild. But why not use the documented names for new hooks we
introduce now?
I can rename them myself, I just wanted to make sure you didn't have
any particular reason for using those names.
next prev parent reply other threads:[~2022-05-21 13:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 0:29 bug#37802: 27.0.50; Feature request: hook for theme enabling/disabling Óscar Fuentes
2022-05-20 10:58 ` Lars Ingebrigtsen
2022-05-20 14:51 ` Óscar Fuentes
2022-05-21 12:56 ` Lars Ingebrigtsen
2022-05-21 13:07 ` Eli Zaretskii
2022-05-21 13:21 ` Lars Ingebrigtsen
2022-05-21 13:25 ` Eli Zaretskii [this message]
2022-05-21 13:26 ` Lars Ingebrigtsen
2022-05-21 16:49 ` Óscar Fuentes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ilpz81ca.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=37802@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=ofv@wanadoo.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).