From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37802: 27.0.50; Feature request: hook for theme enabling/disabling Date: Sat, 21 May 2022 16:07:00 +0300 Message-ID: <83k0af826j.fsf@gnu.org> References: <87d0euopzw.fsf@telefonica.net> <87fsl44gji.fsf@gnus.org> <87fsl45kaw.fsf@telefonica.net> <871qwnyrgd.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35043"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ofv@wanadoo.es, 37802@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 21 15:08:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nsOqH-0008xv-Ke for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 May 2022 15:08:25 +0200 Original-Received: from localhost ([::1]:39684 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nsOqF-0002N0-SC for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 May 2022 09:08:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55130) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsOpv-0002Mb-GX for bug-gnu-emacs@gnu.org; Sat, 21 May 2022 09:08:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47036) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nsOpu-0002jf-HD for bug-gnu-emacs@gnu.org; Sat, 21 May 2022 09:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nsOpu-0005JV-8O for bug-gnu-emacs@gnu.org; Sat, 21 May 2022 09:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 May 2022 13:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37802 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 37802-submit@debbugs.gnu.org id=B37802.165313844120370 (code B ref 37802); Sat, 21 May 2022 13:08:02 +0000 Original-Received: (at 37802) by debbugs.gnu.org; 21 May 2022 13:07:21 +0000 Original-Received: from localhost ([127.0.0.1]:40933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsOpF-0005IU-41 for submit@debbugs.gnu.org; Sat, 21 May 2022 09:07:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsOpB-0005IG-OQ for 37802@debbugs.gnu.org; Sat, 21 May 2022 09:07:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52138) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsOp6-0002gb-04; Sat, 21 May 2022 09:07:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=GdjwWEo8iaVdNX6TIAio+bXlQ5+9mdLZyqIuC69HzqA=; b=fCNPxjkXbcxI9nK6kZrT 77qWb2a/jv2+b5FhZxgFlxVlvSOLb/nFz+NdmX9dvhFSvyGNuz4McEhEvIJm7CnwgzcrAYSdokwnN 1VrW0uBsmq1xZaLNVY9RuX5UCtJEvRYHwF06xuHF4CrlajAcIYhu96HaSlP8i9DlQAgCAYN+w454m PiJevjwXC1xyNtlBmBqI6hLR8q6EKdMtWZeeof4zGuGKwr5Qz7hfjg0oUMUtd2YWWB3RCBGWLFAdB nRzuGRF7TBEqn1kIsB31bRqzodKUkxJdD/gHiqCI8S05+OhiVIGLMh6p3/nGZ9Nb6LIw7WCy/WOcG 1MI7W7JLka7avg==; Original-Received: from [87.69.77.57] (port=1980 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsOp5-0004YG-Fh; Sat, 21 May 2022 09:07:11 -0400 In-Reply-To: <871qwnyrgd.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 21 May 2022 14:56:34 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:232826 Archived-At: > Resent-From: Lars Ingebrigtsen > Original-Sender: "Debbugs-submit" > Resent-CC: bug-gnu-emacs@gnu.org > Resent-Sender: help-debbugs@gnu.org > Cc: 37802@debbugs.gnu.org > From: Lars Ingebrigtsen > Date: Sat, 21 May 2022 14:56:34 +0200 > > Óscar Fuentes writes: > > > Currently I've solved my requirement by using defadvice on enable-theme > > *and* disable-theme for adapting my custom faces to changes on the > > active theme(s). Using a hook would be a little bit cleaner. I'm also > > surprised that no hook was implemented for this case, as most changes on > > user-visible state has an associated hook. > > Yes, true. So I've now added these two hooks to Emacs 29. Thanks, but is there any reason these hooks aren't called enable-theme-function and disable-theme-function? Hooks by such names are already documented as "abnormal hooks", which would avoid the need of saying these new hooks are "atypical", something that we never had in our terminology.