From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37473: 27.0.50; antialias setting is not preserved by, inheriting Date: Sun, 19 Jun 2022 22:14:53 +0300 Message-ID: <83k09cmpn6.fsf@gnu.org> References: <466d6eb8-b02f-9e49-6c79-95c5fa3d7252@orange.fr> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8758"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 37473@debbugs.gnu.org To: David Ponce , Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 19 21:16:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o30P9-00028g-GR for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Jun 2022 21:16:15 +0200 Original-Received: from localhost ([::1]:33602 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o30P8-0005sv-2k for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Jun 2022 15:16:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49132) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o30Ow-0005sU-Gd for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2022 15:16:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59350) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o30Ow-0002Dc-8c for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2022 15:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o30Ov-0003zE-T3 for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2022 15:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Jun 2022 19:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37473 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 37473-submit@debbugs.gnu.org id=B37473.165566612412953 (code B ref 37473); Sun, 19 Jun 2022 19:16:01 +0000 Original-Received: (at 37473) by debbugs.gnu.org; 19 Jun 2022 19:15:24 +0000 Original-Received: from localhost ([127.0.0.1]:53247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o30OK-0003MR-2z for submit@debbugs.gnu.org; Sun, 19 Jun 2022 15:15:24 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o30OG-0003DX-1R for 37473@debbugs.gnu.org; Sun, 19 Jun 2022 15:15:22 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33820) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o30OA-0002Bq-De; Sun, 19 Jun 2022 15:15:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2/4F7VuIbesguhb0Ih8ovaYs1JHcvxW8m/tCSksTFMY=; b=PookeOaUxXpM FTQ5uAIWttDiqGtTgaIqjsr9XBQKhoMmEsNMTO1DSrl/ab2g4qgXW+yaUl0aCLEq/f2yzuvmjA+Yg f9QjGskNM2znV0sEqkVEb5e+HjgnAXrglu+kDqQd9GsLw9C1nQRQzM+wL1Kk/5zZMBIWftCATiIWj l42zOAzNs8ZeSCPn3fg7DO176dhBgMhB8rxYThIsmC2RQqTigwqAuiIwKaMtH6Imd/Z6oLFhhWQVl gJ0ZhpBMSkaRgJkG97sv8TraGHa+ziOhVTxw0xCdQqP5M5HODsEMQlTnJByUr0x3o18Ixiuskgx6+ 6xq+j3N3A6vJNJn9DAqBJQ==; Original-Received: from [87.69.77.57] (port=4558 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o30O6-0006G1-6c; Sun, 19 Jun 2022 15:15:14 -0400 In-Reply-To: <466d6eb8-b02f-9e49-6c79-95c5fa3d7252@orange.fr> (message from David Ponce on Sun, 19 Jun 2022 18:43:33 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234815 Archived-At: > Cc: Lars Ingebrigtsen > Date: Sun, 19 Jun 2022 18:43:33 +0200 > From: David Ponce > > The below related today's commit to xface.c breaks antialiasing: > > From b2d11d69dd49864874f8fe53669b4049e83bfce9 Mon Sep 17 00:00:00 2001 > From: Po Lu > Date: Sun, 19 Jun 2022 21:57:11 +0800 > Subject: More conservative fix for bug#37473 > > * src/xfaces.c (realize_gui_face): Add more conservative fix, > since the last change makes C-x C-+ lead to weight weirdness on > my machine. FWIW, I understand neither that commit nor the one it attempted to fix. First, why is :antialiasing being singled out? won't the same happen for any attribute in FONT_EXTRA_INDEX, like :hinting, :hintstyle, and whatnot? And if indeed the issue is with FONT_EXTRA_INDEX, then I'd first ask why the right value is not in attrs[] in the first place? Because if it is there, why not just use it directly, instead of via Ffont_put? And in addition, why does it make sense to reset foundry, family, registry, and adstyle of the font in attrs[]? don't we want the same font, for example, when resizing the text? IOW, do we really understand the reason for bug#37473? Not the commit which introduced it, but the reason why :antialiasing is being reset and doesn't appear in attrs[] and in the realized face? If so, could someone please spell that out?