From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48408: BUGFIX: window-default-font-height: check for nil string Date: Sun, 16 May 2021 12:08:59 +0300 Message-ID: <83im3jujtg.fsf@gnu.org> References: <20210514011519.vsy5jbhyxd4v6kpt@E15-2016.optimum.net> <83mtsxzund.fsf@gnu.org> <20210516030618.7caj6icukblavhbp@E15-2016.optimum.net> <835yzjwbnj.fsf@gnu.org> <20210516044215.23yd5ae3yeby6kaq@E15-2016.optimum.net> <83zgwvuu5z.fsf@gnu.org> <83tun3ur7h.fsf@gnu.org> <20210516065904.5wweuipi23oy5g2x@E15-2016.optimum.net> <83pmxrulm4.fsf@gnu.org> <83lf8fukdu.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9100"; mail-complaints-to="usenet@ciao.gmane.io" Cc: boruch_baum@gmx.com, 48408@debbugs.gnu.org To: rudalics@gmx.at Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 16 11:12:07 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1liCoh-0002H4-N1 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 May 2021 11:12:07 +0200 Original-Received: from localhost ([::1]:42540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liCog-0007pF-QC for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 May 2021 05:12:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liCmm-0007KA-QZ for bug-gnu-emacs@gnu.org; Sun, 16 May 2021 05:10:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38167) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1liCmi-0000cS-Uf for bug-gnu-emacs@gnu.org; Sun, 16 May 2021 05:10:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1liCmg-0002h1-OJ for bug-gnu-emacs@gnu.org; Sun, 16 May 2021 05:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 May 2021 09:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48408 X-GNU-PR-Package: emacs Original-Received: via spool by 48408-submit@debbugs.gnu.org id=B48408.162115614410255 (code B ref 48408); Sun, 16 May 2021 09:10:02 +0000 Original-Received: (at 48408) by debbugs.gnu.org; 16 May 2021 09:09:04 +0000 Original-Received: from localhost ([127.0.0.1]:49709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liClk-0002fK-HF for submit@debbugs.gnu.org; Sun, 16 May 2021 05:09:04 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liClj-0002er-3O for 48408@debbugs.gnu.org; Sun, 16 May 2021 05:09:03 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45234) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liCld-0000BN-M2; Sun, 16 May 2021 05:08:57 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1126 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liCld-0001Yw-5X; Sun, 16 May 2021 05:08:57 -0400 In-Reply-To: <83lf8fukdu.fsf@gnu.org> (message from Eli Zaretskii on Sun, 16 May 2021 11:56:45 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206649 Archived-At: > Date: Sun, 16 May 2021 11:56:45 +0300 > From: Eli Zaretskii > Cc: boruch_baum@gmx.com, 48408@debbugs.gnu.org > > > OK. But was Boruch's original idea just checking for > > > > (stringp default-font) > > > > worse? > > I'm asking for your opinion about that ;-) Actually, no, I do have an opinion on that: face-font can return a string even on a TTY frame, at least in a build --without-x. (Which seems to be an inconsistency in and of itself, btw.) In general, trusting frame parameters too much is IME not a good idea, as they are too loosely defined.