From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37802: 27.0.50; Feature request: hook for theme enabling/disabling Date: Sat, 21 May 2022 16:25:09 +0300 Message-ID: <83ilpz81ca.fsf@gnu.org> References: <87d0euopzw.fsf@telefonica.net> <87fsl44gji.fsf@gnus.org> <87fsl45kaw.fsf@telefonica.net> <871qwnyrgd.fsf@gnus.org> <83k0af826j.fsf@gnu.org> <87tu9jxbqe.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1769"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ofv@wanadoo.es, 37802@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 21 15:26:39 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nsP7t-0000HX-Sn for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 May 2022 15:26:38 +0200 Original-Received: from localhost ([::1]:41758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nsP7s-0005M9-Gv for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 May 2022 09:26:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57978) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsP7K-0005Lt-Ui for bug-gnu-emacs@gnu.org; Sat, 21 May 2022 09:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47084) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nsP7K-0005kE-Jw for bug-gnu-emacs@gnu.org; Sat, 21 May 2022 09:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nsP7K-0005p7-GB for bug-gnu-emacs@gnu.org; Sat, 21 May 2022 09:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 May 2022 13:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37802 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 37802-submit@debbugs.gnu.org id=B37802.165313953322339 (code B ref 37802); Sat, 21 May 2022 13:26:02 +0000 Original-Received: (at 37802) by debbugs.gnu.org; 21 May 2022 13:25:33 +0000 Original-Received: from localhost ([127.0.0.1]:40981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsP6r-0005oE-Ae for submit@debbugs.gnu.org; Sat, 21 May 2022 09:25:33 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nsP6p-0005o2-Qa for 37802@debbugs.gnu.org; Sat, 21 May 2022 09:25:32 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52288) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsP6k-0005bJ-8d; Sat, 21 May 2022 09:25:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dO9rFJkGvNuo0Oc3rRgnArSVrgrSoXyLH/tCo7bqKdk=; b=mTRNBSvYRs5I w+rc3I0OVdSfqBz8unaeHM+zoBiSWH9nXD2tYhan0wpy2Qb4kf+xD8sOyUH2+Sv5TNwPWuclXSEFG RxepkLgTAfWErRHu1lWxTHaNgy5nnlEsZ9o9O/bxsyyi7x+x9JdmaBks+suzLROVeFE2fhmw47+qP orQCRPwCHW89Kcpo5JNJYSfTquRIgBZN+z5uROXh4qEgG+d4Q10jd2uApi534T6mwQ3cetrfHwQWU dCQlU6WxrA6T43cKypcVstNNqxggjb2id/n7NZPt0JHvSSkDd/4UWQmWlxZOBGZu9Qlx8gAIOFNMZ R/jJzKtRsvxX3VKIUe/P8Q==; Original-Received: from [87.69.77.57] (port=3093 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsP6d-0006Si-LT; Sat, 21 May 2022 09:25:25 -0400 In-Reply-To: <87tu9jxbqe.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 21 May 2022 15:21:29 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:232828 Archived-At: > From: Lars Ingebrigtsen > Cc: ofv@wanadoo.es, 37802@debbugs.gnu.org > Date: Sat, 21 May 2022 15:21:29 +0200 > > Eli Zaretskii writes: > > > Thanks, but is there any reason these hooks aren't called > > enable-theme-function and disable-theme-function? Hooks by such > > names are already documented as "abnormal hooks", which would avoid > > the need of saying these new hooks are "atypical", something that we > > never had in our terminology. > > "Abnormal" was the word I was looking for. > > As for the name, I don't really have much of an opinion -- we have more > of these abnormal hooks called -hook than -function(s), a short grepping > for run-hook-with-args shows. Maybe so, and we cannot do much about bad names that are already in the wild. But why not use the documented names for new hooks we introduce now? I can rename them myself, I just wanted to make sure you didn't have any particular reason for using those names.