From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50630: [External] : bug#50630: 28.0.50; list-directory shows free space for current directory, not the specified one Date: Sat, 18 Sep 2021 08:56:45 +0300 Message-ID: <83h7ei77fm.fsf@gnu.org> References: <83lf3v8ysw.fsf@gnu.org> <83r1dn6pub.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19034"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50630-done@debbugs.gnu.org To: John Cummings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 18 07:58:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRTMY-0004kN-5w for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Sep 2021 07:58:10 +0200 Original-Received: from localhost ([::1]:42512 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRTMW-0000DP-JO for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Sep 2021 01:58:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46158) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRTMQ-0000D4-VF for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 01:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50066) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mRTMQ-0002Bt-Nn for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 01:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mRTMQ-0002yT-LI for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 01:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Sep 2021 05:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50630 X-GNU-PR-Package: emacs Original-Received: via spool by 50630-done@debbugs.gnu.org id=D50630.163194463111281 (code D ref 50630); Sat, 18 Sep 2021 05:58:02 +0000 Original-Received: (at 50630-done) by debbugs.gnu.org; 18 Sep 2021 05:57:11 +0000 Original-Received: from localhost ([127.0.0.1]:33375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRTLa-0002vo-IC for submit@debbugs.gnu.org; Sat, 18 Sep 2021 01:57:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRTLV-0002v0-5h for 50630-done@debbugs.gnu.org; Sat, 18 Sep 2021 01:57:08 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41322) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRTLO-0001I7-Rn; Sat, 18 Sep 2021 01:56:58 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3649 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRTLO-0002s1-FZ; Sat, 18 Sep 2021 01:56:58 -0400 In-Reply-To: (message from John Cummings on Fri, 17 Sep 2021 20:32:53 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214597 Archived-At: > Date: Fri, 17 Sep 2021 20:32:53 +0000 > From: John Cummings > Cc: Drew Adams , 50630-done@debbugs.gnu.org > > On Friday, September 17th, 2021 at 2:04 PM, Eli Zaretskii wrote: > > > > From: Drew Adams drew.adams@oracle.com > > > I believe the same change is needed in ls-lisp.el, for function `ls-lisp--insert-directory'. > > > > > > (let ((available (get-free-disk-space "."))) > > > > > > should be: > > > > > > (let ((available (get-free-disk-space file))) > > > > Why, do you see the wrong values being reported? > > The values look wrong to me here. In my testing, they reflect the correct volume (because the call is in the buffer whose default-directory is set to the directory we are going to display), which is why I installed the changes. Please tell how you test, starting from "emacs -Q", because I'd like to look at this. > Thanks for the heads up. I've got a working test for files.el and ls-lisp.el, and after I polish it, I'll also look into how to handle FILE vs ORIG-FILE Thanks.